mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: David Caro <>
Subject: Skipping adding Signed-off-by even if it's not the last on git commit
Date: Tue, 6 Dec 2022 18:06:46 +0100	[thread overview]
Message-ID: <20221206170646.6lnpr6h7oprziy5b@vulcanus> (raw)

[-- Attachment #1: Type: text/plain, Size: 856 bytes --]


I have noticed that when requesting git commit to add the Signed-off-by header, it will add it even if it already exists
as long as it's not the last in the footer.

It seems that the functionality to do so has been there for a while (see [1]) and it's being used effectively on
format-patch, but it was never enabled for the rest of commands.

I propose enabling it for commit, merge and am.

I can easily send a patch for it if the change is welcome.



David Caro
SRE - Cloud Services
Wikimedia Foundation <>
PGP Signature: 7180 83A2 AC8B 314F B4CE  1171 4071 C7E1 D262 69C3

"Imagine a world in which every single human being can freely share in the
sum of all knowledge. That's our commitment."

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2022-12-06 17:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06 17:06 David Caro [this message]
2022-12-07  1:50 ` Skipping adding Signed-off-by even if it's not the last on git commit Taylor Blau
2022-12-07  4:11   ` Junio C Hamano
2022-12-07  8:40     ` David Caro
2022-12-07 22:13       ` Taylor Blau
2022-12-07 23:04         ` Junio C Hamano
2022-12-08  7:27           ` Jeff King
2022-12-09  1:23             ` Junio C Hamano
2022-12-09  1:42               ` Jeff King
2022-12-09  4:03                 ` Junio C Hamano
2022-12-09 20:39                   ` Jeff King
2022-12-07  4:31   ` Ævar Arnfjörð Bjarmason
2022-12-07  4:57     ` Junio C Hamano
2022-12-07 15:00     ` Konstantin Ryabitsev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221206170646.6lnpr6h7oprziy5b@vulcanus \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).