From: Jiang Xin <worldhello.net@gmail.com>
To: "Git List" <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Jiang Xin <zhiyou.jx@alibaba-inc.com>,
Jiang Xin <worldhello.net@gmail.com>
Subject: [PATCH v3 0/3] t1301: various updates
Date: Tue, 29 Nov 2022 21:15:08 +0800 [thread overview]
Message-ID: <20221129131511.7173-1-worldhello.net@gmail.com> (raw)
In-Reply-To: <20221128130323.8914-1-worldhello.net@gmail.com>
From: Jiang Xin <zhiyou.jx@alibaba-inc.com>
Various updates for t1301:
* t1301: fix wrong template dir for git-init
* t1301: use test_when_finished for cleanup
* t1301: do not change $CWD in "shared=all" test case
## range-diff v2...v3
1: bc68ffb41c = 1: 7a66766a10 t1301: fix wrong template dir for git-init
2: ae2b2f8afc = 2: 97eefb1e67 t1301: use test_when_finished for cleanup
3: f1bf255e5a ! 3: 9575f2eb1c t1301: do not change $CWD in "shared=all" test case
@@ Commit message
So it is a safe change for us to run the test case "shared=all" in
current repository instead of creating and changing to "sub".
- For the next test case, we no longer run it in the "sub" repository
- which is initialized from an empty template, we should not assume the
- path ".git/info" is missing. So add option "-p" to mkdir.
+ For the next test case, the path ".git/info" is assumed to be missing,
+ but we no longer run the test case in the "sub" repository which is
+ initialized from an empty template. In order for the test case to run
+ properly, we can set "TEST_CREATE_REPO_NO_TEMPLATE=1" to initialize the
+ default repository without a template.
Helped-by: Junio C Hamano <gitster@pobox.com>
+ Helped-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Jiang Xin <zhiyou.jx@alibaba-inc.com>
## t/t1301-shared-repo.sh ##
+@@ t/t1301-shared-repo.sh: test_description='Test shared repository initialization'
+ GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
+ export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
+
++TEST_CREATE_REPO_NO_TEMPLATE=1
+ . ./test-lib.sh
+
+ # Remove a default ACL from the test dir if possible.
@@ t/t1301-shared-repo.sh: do
done
@@ t/t1301-shared-repo.sh: do
git init --template= --shared=all &&
test 2 = $(git config core.sharedrepository)
'
-@@ t/t1301-shared-repo.sh: test_expect_success POSIXPERM 'update-server-info honors core.sharedRepository'
- git add a1 &&
- test_tick &&
- git commit -m a1 &&
-- mkdir .git/info &&
-+ mkdir -p .git/info &&
- umask 0277 &&
- git update-server-info &&
- actual="$(ls -l .git/info/refs)" &&
--
Jiang Xin (3):
t1301: fix wrong template dir for git-init
t1301: use test_when_finished for cleanup
t1301: do not change $CWD in "shared=all" test case
t/t1301-shared-repo.sh | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
--
2.39.0.rc0
next prev parent reply other threads:[~2022-11-29 13:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-27 14:51 [PATCH v1 1/4] t1301: fix wrong template dir for git-init Jiang Xin
2022-11-27 14:51 ` [PATCH v1 2/4] t1301: use test_when_finished for cleanup Jiang Xin
2022-11-28 4:11 ` Junio C Hamano
2022-11-27 14:51 ` [PATCH v1 3/4] t1301: wrap the statements in the for loop Jiang Xin
2022-11-28 4:18 ` Junio C Hamano
2022-11-28 9:43 ` Jiang Xin
2022-11-28 11:56 ` Jiang Xin
2022-11-27 14:51 ` [PATCH v1 4/4] t1301: do not change $CWD in "shared=all" test case Jiang Xin
2022-11-28 4:41 ` Junio C Hamano
2022-11-28 9:46 ` Jiang Xin
2022-11-28 13:03 ` [PATCH v2 0/3] t1301: various updates Jiang Xin
2022-11-29 13:15 ` Jiang Xin [this message]
2022-11-29 13:15 ` [PATCH v3 1/3] t1301: fix wrong template dir for git-init Jiang Xin
2022-11-29 13:15 ` [PATCH v3 2/3] t1301: use test_when_finished for cleanup Jiang Xin
2022-11-29 13:15 ` [PATCH v3 3/3] t1301: do not change $CWD in "shared=all" test case Jiang Xin
2022-11-28 13:03 ` [PATCH v2 1/3] t1301: fix wrong template dir for git-init Jiang Xin
2022-11-28 13:24 ` Ævar Arnfjörð Bjarmason
2022-11-28 14:12 ` Jiang Xin
2022-11-28 14:21 ` Ævar Arnfjörð Bjarmason
2022-11-28 13:03 ` [PATCH v2 2/3] t1301: use test_when_finished for cleanup Jiang Xin
2022-11-28 13:03 ` [PATCH v2 3/3] t1301: do not change $CWD in "shared=all" test case Jiang Xin
2022-11-28 13:18 ` Ævar Arnfjörð Bjarmason
2022-11-28 14:29 ` Jiang Xin
2022-11-29 0:30 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221129131511.7173-1-worldhello.net@gmail.com \
--to=worldhello.net@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=zhiyou.jx@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).