From: Jiang Xin <worldhello.net@gmail.com>
To: Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Heikki Orsila <heikki.orsila@iki.fi>
Cc: Jiang Xin <zhiyou.jx@alibaba-inc.com>,
Jiang Xin <worldhello.net@gmail.com>
Subject: [PATCH v1 3/4] t1301: wrap the statements in the for loop
Date: Sun, 27 Nov 2022 22:51:29 +0800 [thread overview]
Message-ID: <20221127145130.16155-3-worldhello.net@gmail.com> (raw)
In-Reply-To: <20221127145130.16155-1-worldhello.net@gmail.com>
From: Jiang Xin <zhiyou.jx@alibaba-inc.com>
Wrap the statements which were introduced in commit 06cbe85503 (Make
core.sharedRepository more generic, 2008-04-16)) in the for loop in a
new test case, so if we want to skip some of the test cases, these
unwrapped statements won't affect the test cases we choose to run.
Signed-off-by: Jiang Xin <zhiyou.jx@alibaba-inc.com>
---
t/t1301-shared-repo.sh | 19 ++++++++-----------
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/t/t1301-shared-repo.sh b/t/t1301-shared-repo.sh
index 1225abbb6d..3ca91bf504 100755
--- a/t/t1301-shared-repo.sh
+++ b/t/t1301-shared-repo.sh
@@ -78,31 +78,28 @@ for u in 0660:rw-rw---- \
0666:rw-rw-rw- \
0664:rw-rw-r--
do
- x=$(expr "$u" : ".*:\([rw-]*\)") &&
- y=$(echo "$x" | sed -e "s/w/-/g") &&
- u=$(expr "$u" : "\([0-7]*\)") &&
- git config core.sharedrepository "$u" &&
- umask 0277 &&
+ test_expect_success POSIXPERM "set variables from $u" '
+ x=$(expr "$u" : ".*:\([rw-]*\)") &&
+ y=$(echo "$x" | sed -e "s/w/-/g") &&
+ u=$(expr "$u" : "\([0-7]*\)") &&
+ git config core.sharedrepository "$u"
+ '
test_expect_success POSIXPERM "shared = $u ($y) ro" '
-
+ umask 0277 &&
rm -f .git/info/refs &&
git update-server-info &&
actual="$(test_modebits .git/info/refs)" &&
verbose test "x$actual" = "x-$y"
-
'
- umask 077 &&
test_expect_success POSIXPERM "shared = $u ($x) rw" '
-
+ umask 077 &&
rm -f .git/info/refs &&
git update-server-info &&
actual="$(test_modebits .git/info/refs)" &&
verbose test "x$actual" = "x-$x"
-
'
-
done
test_expect_success POSIXPERM 'info/refs respects umask in unshared repo' '
--
2.39.0.rc0
next prev parent reply other threads:[~2022-11-27 14:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-27 14:51 [PATCH v1 1/4] t1301: fix wrong template dir for git-init Jiang Xin
2022-11-27 14:51 ` [PATCH v1 2/4] t1301: use test_when_finished for cleanup Jiang Xin
2022-11-28 4:11 ` Junio C Hamano
2022-11-27 14:51 ` Jiang Xin [this message]
2022-11-28 4:18 ` [PATCH v1 3/4] t1301: wrap the statements in the for loop Junio C Hamano
2022-11-28 9:43 ` Jiang Xin
2022-11-28 11:56 ` Jiang Xin
2022-11-27 14:51 ` [PATCH v1 4/4] t1301: do not change $CWD in "shared=all" test case Jiang Xin
2022-11-28 4:41 ` Junio C Hamano
2022-11-28 9:46 ` Jiang Xin
2022-11-28 13:03 ` [PATCH v2 0/3] t1301: various updates Jiang Xin
2022-11-29 13:15 ` [PATCH v3 " Jiang Xin
2022-11-29 13:15 ` [PATCH v3 1/3] t1301: fix wrong template dir for git-init Jiang Xin
2022-11-29 13:15 ` [PATCH v3 2/3] t1301: use test_when_finished for cleanup Jiang Xin
2022-11-29 13:15 ` [PATCH v3 3/3] t1301: do not change $CWD in "shared=all" test case Jiang Xin
2022-11-28 13:03 ` [PATCH v2 1/3] t1301: fix wrong template dir for git-init Jiang Xin
2022-11-28 13:24 ` Ævar Arnfjörð Bjarmason
2022-11-28 14:12 ` Jiang Xin
2022-11-28 14:21 ` Ævar Arnfjörð Bjarmason
2022-11-28 13:03 ` [PATCH v2 2/3] t1301: use test_when_finished for cleanup Jiang Xin
2022-11-28 13:03 ` [PATCH v2 3/3] t1301: do not change $CWD in "shared=all" test case Jiang Xin
2022-11-28 13:18 ` Ævar Arnfjörð Bjarmason
2022-11-28 14:29 ` Jiang Xin
2022-11-29 0:30 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221127145130.16155-3-worldhello.net@gmail.com \
--to=worldhello.net@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=heikki.orsila@iki.fi \
--cc=zhiyou.jx@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).