* [PATCH] configure.ac: fix HAVE_SYNC_FILE_RANGE definition
@ 2022-04-05 10:00 Adam Dinwoodie
2022-04-05 15:31 ` Neeraj Singh
0 siblings, 1 reply; 3+ messages in thread
From: Adam Dinwoodie @ 2022-04-05 10:00 UTC (permalink / raw)
To: git; +Cc: Neeraj Singh
If sync_file_range is not available when building the configure script,
there is a cosmetic bug when running that script reporting
"HAVE_SYNC_FILE_RANGE: command not found". Remove that error message by
defining HAVE_SYNC_FILE_RANGE to an empty string, rather than generating
a script where that appears as a bare command.
Signed-off-by: Adam Dinwoodie <adam@dinwoodie.org>
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 6bd6bef1c4..316a31d231 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1087,7 +1087,7 @@ GIT_CONF_SUBST([HAVE_CLOCK_MONOTONIC])
# Define HAVE_SYNC_FILE_RANGE=YesPlease if sync_file_range is available.
GIT_CHECK_FUNC(sync_file_range,
[HAVE_SYNC_FILE_RANGE=YesPlease],
- [HAVE_SYNC_FILE_RANGE])
+ [HAVE_SYNC_FILE_RANGE=])
GIT_CONF_SUBST([HAVE_SYNC_FILE_RANGE])
#
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] configure.ac: fix HAVE_SYNC_FILE_RANGE definition
2022-04-05 10:00 [PATCH] configure.ac: fix HAVE_SYNC_FILE_RANGE definition Adam Dinwoodie
@ 2022-04-05 15:31 ` Neeraj Singh
2022-04-06 16:35 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Neeraj Singh @ 2022-04-05 15:31 UTC (permalink / raw)
To: Adam Dinwoodie; +Cc: git, Neeraj Singh
On Tue, Apr 05, 2022 at 11:00:20AM +0100, Adam Dinwoodie wrote:
> If sync_file_range is not available when building the configure script,
> there is a cosmetic bug when running that script reporting
> "HAVE_SYNC_FILE_RANGE: command not found". Remove that error message by
> defining HAVE_SYNC_FILE_RANGE to an empty string, rather than generating
> a script where that appears as a bare command.
>
> Signed-off-by: Adam Dinwoodie <adam@dinwoodie.org>
> ---
> configure.ac | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 6bd6bef1c4..316a31d231 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1087,7 +1087,7 @@ GIT_CONF_SUBST([HAVE_CLOCK_MONOTONIC])
> # Define HAVE_SYNC_FILE_RANGE=YesPlease if sync_file_range is available.
> GIT_CHECK_FUNC(sync_file_range,
> [HAVE_SYNC_FILE_RANGE=YesPlease],
> - [HAVE_SYNC_FILE_RANGE])
> + [HAVE_SYNC_FILE_RANGE=])
> GIT_CONF_SUBST([HAVE_SYNC_FILE_RANGE])
>
> #
> --
> 2.35.1
>
Thanks for fixing this. Looks good to me.
-Neeraj
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] configure.ac: fix HAVE_SYNC_FILE_RANGE definition
2022-04-05 15:31 ` Neeraj Singh
@ 2022-04-06 16:35 ` Junio C Hamano
0 siblings, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2022-04-06 16:35 UTC (permalink / raw)
To: Neeraj Singh; +Cc: Adam Dinwoodie, git, Neeraj Singh
Neeraj Singh <nksingh85@gmail.com> writes:
> On Tue, Apr 05, 2022 at 11:00:20AM +0100, Adam Dinwoodie wrote:
>> If sync_file_range is not available when building the configure script,
>> there is a cosmetic bug when running that script reporting
>> "HAVE_SYNC_FILE_RANGE: command not found". Remove that error message by
>> defining HAVE_SYNC_FILE_RANGE to an empty string, rather than generating
>> a script where that appears as a bare command.
>>
>> Signed-off-by: Adam Dinwoodie <adam@dinwoodie.org>
>> ---
>> configure.ac | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 6bd6bef1c4..316a31d231 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -1087,7 +1087,7 @@ GIT_CONF_SUBST([HAVE_CLOCK_MONOTONIC])
>> # Define HAVE_SYNC_FILE_RANGE=YesPlease if sync_file_range is available.
>> GIT_CHECK_FUNC(sync_file_range,
>> [HAVE_SYNC_FILE_RANGE=YesPlease],
>> - [HAVE_SYNC_FILE_RANGE])
>> + [HAVE_SYNC_FILE_RANGE=])
>> GIT_CONF_SUBST([HAVE_SYNC_FILE_RANGE])
>>
>> #
>> --
>> 2.35.1
>>
>
> Thanks for fixing this. Looks good to me.
Thanks, both.
Will apply.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-06 18:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-05 10:00 [PATCH] configure.ac: fix HAVE_SYNC_FILE_RANGE definition Adam Dinwoodie
2022-04-05 15:31 ` Neeraj Singh
2022-04-06 16:35 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).