* [PATCH 0/5] Remove. duplicate include directives
@ 2022-03-13 19:55 Elia Pinto
2022-03-13 19:55 ` [PATCH 1/5] attr.c: delete duplicate include Elia Pinto
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: Elia Pinto @ 2022-03-13 19:55 UTC (permalink / raw)
To: git; +Cc: Elia Pinto
This series of patches does not solve any particular problems but
only eliminates unnecessary duplicate include directives
from git sources
Elia Pinto (5):
attr.c: delete duplicate include
builtin/gc.c: delete duplicate include
builtin/sparse-checkout.c: delete duplicate include
builtin/stash.c: delete duplicate include
t/helper/test-run-command.c: delete duplicate include
attr.c | 1 -
builtin/gc.c | 1 -
builtin/sparse-checkout.c | 1 -
builtin/stash.c | 1 -
t/helper/test-run-command.c | 1 -
5 files changed, 5 deletions(-)
--
2.35.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/5] attr.c: delete duplicate include
2022-03-13 19:55 [PATCH 0/5] Remove. duplicate include directives Elia Pinto
@ 2022-03-13 19:55 ` Elia Pinto
2022-03-13 19:55 ` [PATCH 2/5] builtin/gc.c: " Elia Pinto
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Elia Pinto @ 2022-03-13 19:55 UTC (permalink / raw)
To: git; +Cc: Elia Pinto
dir.h is included more than once
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
attr.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/attr.c b/attr.c
index 79adaa50ea..1626cade8b 100644
--- a/attr.c
+++ b/attr.c
@@ -14,7 +14,6 @@
#include "utf8.h"
#include "quote.h"
#include "thread-utils.h"
-#include "dir.h"
const char git_attr__true[] = "(builtin)true";
const char git_attr__false[] = "\0(builtin)false";
--
2.35.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/5] builtin/gc.c: delete duplicate include
2022-03-13 19:55 [PATCH 0/5] Remove. duplicate include directives Elia Pinto
2022-03-13 19:55 ` [PATCH 1/5] attr.c: delete duplicate include Elia Pinto
@ 2022-03-13 19:55 ` Elia Pinto
2022-03-13 19:55 ` [PATCH 3/5] builtin/sparse-checkout.c: " Elia Pinto
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Elia Pinto @ 2022-03-13 19:55 UTC (permalink / raw)
To: git; +Cc: Elia Pinto
object-store.h is included more than once.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
builtin/gc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/builtin/gc.c b/builtin/gc.c
index ffaf0daf5d..b335cffa33 100644
--- a/builtin/gc.c
+++ b/builtin/gc.c
@@ -30,7 +30,6 @@
#include "promisor-remote.h"
#include "refs.h"
#include "remote.h"
-#include "object-store.h"
#include "exec-cmd.h"
#include "hook.h"
--
2.35.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/5] builtin/sparse-checkout.c: delete duplicate include
2022-03-13 19:55 [PATCH 0/5] Remove. duplicate include directives Elia Pinto
2022-03-13 19:55 ` [PATCH 1/5] attr.c: delete duplicate include Elia Pinto
2022-03-13 19:55 ` [PATCH 2/5] builtin/gc.c: " Elia Pinto
@ 2022-03-13 19:55 ` Elia Pinto
2022-03-13 19:55 ` [PATCH 4/5] builtin/stash.c: " Elia Pinto
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Elia Pinto @ 2022-03-13 19:55 UTC (permalink / raw)
To: git; +Cc: Elia Pinto
cache.h is included more than once.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
builtin/sparse-checkout.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/builtin/sparse-checkout.c b/builtin/sparse-checkout.c
index 5518ed47f6..d88d141076 100644
--- a/builtin/sparse-checkout.c
+++ b/builtin/sparse-checkout.c
@@ -8,7 +8,6 @@
#include "run-command.h"
#include "strbuf.h"
#include "string-list.h"
-#include "cache.h"
#include "cache-tree.h"
#include "lockfile.h"
#include "resolve-undo.h"
--
2.35.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 4/5] builtin/stash.c: delete duplicate include
2022-03-13 19:55 [PATCH 0/5] Remove. duplicate include directives Elia Pinto
` (2 preceding siblings ...)
2022-03-13 19:55 ` [PATCH 3/5] builtin/sparse-checkout.c: " Elia Pinto
@ 2022-03-13 19:55 ` Elia Pinto
2022-03-13 19:55 ` [PATCH 5/5] t/helper/test-run-command.c: " Elia Pinto
2022-03-13 22:22 ` [PATCH 0/5] Remove. duplicate include directives Junio C Hamano
5 siblings, 0 replies; 7+ messages in thread
From: Elia Pinto @ 2022-03-13 19:55 UTC (permalink / raw)
To: git; +Cc: Elia Pinto
entry.h is included more than once.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
builtin/stash.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/builtin/stash.c b/builtin/stash.c
index 3e8af210fd..548048f444 100644
--- a/builtin/stash.c
+++ b/builtin/stash.c
@@ -16,7 +16,6 @@
#include "log-tree.h"
#include "diffcore.h"
#include "exec-cmd.h"
-#include "entry.h"
#define INCLUDE_ALL_FILES 2
--
2.35.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 5/5] t/helper/test-run-command.c: delete duplicate include
2022-03-13 19:55 [PATCH 0/5] Remove. duplicate include directives Elia Pinto
` (3 preceding siblings ...)
2022-03-13 19:55 ` [PATCH 4/5] builtin/stash.c: " Elia Pinto
@ 2022-03-13 19:55 ` Elia Pinto
2022-03-13 22:22 ` [PATCH 0/5] Remove. duplicate include directives Junio C Hamano
5 siblings, 0 replies; 7+ messages in thread
From: Elia Pinto @ 2022-03-13 19:55 UTC (permalink / raw)
To: git; +Cc: Elia Pinto
parse-options.h is included more than once.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
t/helper/test-run-command.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/t/helper/test-run-command.c b/t/helper/test-run-command.c
index 8f370cd89f..1b35a143c1 100644
--- a/t/helper/test-run-command.c
+++ b/t/helper/test-run-command.c
@@ -19,7 +19,6 @@
#include "thread-utils.h"
#include "wildmatch.h"
#include "gettext.h"
-#include "parse-options.h"
static int number_callbacks;
static int parallel_next(struct child_process *cp,
--
2.35.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 0/5] Remove. duplicate include directives
2022-03-13 19:55 [PATCH 0/5] Remove. duplicate include directives Elia Pinto
` (4 preceding siblings ...)
2022-03-13 19:55 ` [PATCH 5/5] t/helper/test-run-command.c: " Elia Pinto
@ 2022-03-13 22:22 ` Junio C Hamano
5 siblings, 0 replies; 7+ messages in thread
From: Junio C Hamano @ 2022-03-13 22:22 UTC (permalink / raw)
To: Elia Pinto; +Cc: git
Elia Pinto <gitter.spiros@gmail.com> writes:
> This series of patches does not solve any particular problems but
> only eliminates unnecessary duplicate include directives
> from git sources
>
> Elia Pinto (5):
> attr.c: delete duplicate include
> builtin/gc.c: delete duplicate include
> builtin/sparse-checkout.c: delete duplicate include
> builtin/stash.c: delete duplicate include
> t/helper/test-run-command.c: delete duplicate include
Thanks.
It matches the output from the pipeline:
$ git grep '^#include' \*.c |
sort | uniq -c | sort -n | sed -e '/^ *1 /d'
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-03-13 22:22 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-13 19:55 [PATCH 0/5] Remove. duplicate include directives Elia Pinto
2022-03-13 19:55 ` [PATCH 1/5] attr.c: delete duplicate include Elia Pinto
2022-03-13 19:55 ` [PATCH 2/5] builtin/gc.c: " Elia Pinto
2022-03-13 19:55 ` [PATCH 3/5] builtin/sparse-checkout.c: " Elia Pinto
2022-03-13 19:55 ` [PATCH 4/5] builtin/stash.c: " Elia Pinto
2022-03-13 19:55 ` [PATCH 5/5] t/helper/test-run-command.c: " Elia Pinto
2022-03-13 22:22 ` [PATCH 0/5] Remove. duplicate include directives Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).