git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Fernando Ramos <greenfoo@u92.eu>
To: git@vger.kernel.org
Cc: gitster@pobox.com, davvid@gmail.com, seth@eseth.com,
	levraiphilippeblain@gmail.com, rogi@skylittlesystem.org
Subject: [PATCH 2/3] vimdiff: add tool documentation
Date: Thu,  4 Nov 2021 17:09:58 +0100	[thread overview]
Message-ID: <20211104160959.183402-3-greenfoo@u92.eu> (raw)
In-Reply-To: <20211104160959.183402-1-greenfoo@u92.eu>

Running 'git {merge,diff}tool --tool-help' now also prints usage
information about the vimdiff tool (and its variantes) instead of just
its name.

Two new functions ('diff_cmd_help()' and 'merge_cmd_help()') have been
added to the set of functions that each merge tool (ie. scripts found
inside "mergetools/") can overwrite to provided tool specific
information.

Right now, only 'mergetools/vimdiff' implements these functions, but
other tools are encouraged to do so in the future, specially if they
take configuration options not explained anywhere else (as it is the
case with the 'vimdiff' tool and the new 'layout' option)

Signed-off-by: Fernando Ramos <greenfoo@u92.eu>
---
 git-mergetool--lib.sh |  12 ++
 mergetools/vimdiff    | 272 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 284 insertions(+)

diff --git a/git-mergetool--lib.sh b/git-mergetool--lib.sh
index 542a6a75eb..3964cd8f99 100644
--- a/git-mergetool--lib.sh
+++ b/git-mergetool--lib.sh
@@ -64,6 +64,10 @@ $(list_tool_variants)"
 				fi
 				shown_any=yes
 				printf "%s%s\n" "$per_line_prefix" "$toolname"
+				while IFS= read -r line
+				do
+					printf "%s\t%s\n" "$per_line_prefix" "$line"
+                                done < <(diff_mode && diff_cmd_help "$toolname" || merge_cmd_help "$toolname")
 			fi
 		done
 
@@ -162,10 +166,18 @@ setup_tool () {
 		return 1
 	}
 
+	diff_cmd_help () {
+		return 0
+	}
+
 	merge_cmd () {
 		return 1
 	}
 
+	merge_cmd_help () {
+		return 0
+	}
+
 	hide_resolved_enabled () {
 		return 0
 	}
diff --git a/mergetools/vimdiff b/mergetools/vimdiff
index 1f2e88777e..aa8fbc0a19 100644
--- a/mergetools/vimdiff
+++ b/mergetools/vimdiff
@@ -428,6 +428,46 @@ diff_cmd () {
 		-c 'wincmd l' -c 'cd $GIT_PREFIX' "$LOCAL" "$REMOTE"
 }
 
+diff_cmd_help() {
+	case "$1" in
+	vimdiff)
+		cat <<-ENDOFMESSAGE
+			Opens vim with two vertical windows: LOCAL changes will be placed in the left
+			window and REMOTE changes in the right one.
+		ENDOFMESSAGE
+		;;
+	vimdiff*)
+		cat <<-ENDOFMESSAGE
+			Same as 'vimdiff'
+		ENDOFMESSAGE
+		;;
+	gvimdiff)
+		cat <<-ENDOFMESSAGE
+			Same as 'vimdiff' but opens 'gvim' instead (which uses a graphical toolkit for
+			opening its own window)
+		ENDOFMESSAGE
+		;;
+	gvimdiff*)
+		cat <<-ENDOFMESSAGE
+			Same as 'gvimdiff'
+		ENDOFMESSAGE
+		;;
+	nvimdiff)
+		cat <<-ENDOFMESSAGE
+			Same as 'vimdiff' but opens 'neovim' instead (which is a fork of the original
+			'vim' 'focused on extensibility and usability' according to their authors)
+		ENDOFMESSAGE
+		;;
+	nvimdiff*)
+		cat <<-ENDOFMESSAGE
+			Same as 'nvimdiff'
+		ENDOFMESSAGE
+		;;
+	esac
+
+	return 0
+}
+
 
 merge_cmd () {
 	layout=$(git config mergetool.$merge_tool.layout)
@@ -503,6 +543,238 @@ merge_cmd () {
 	return "$ret"
 }
 
+merge_cmd_help() {
+	case "$1" in
+	vimdiff)
+		cat <<-ENDOFMESSAGE
+			Opens vim with a 4 windows layout distributed in the following way:
+			
+			    ------------------------------------------
+			    |             |           |              |
+			    |   LOCAL     |   BASE    |   REMOTE     |
+			    |             |           |              |
+			    ------------------------------------------
+			    |                                        |
+			    |                MERGED                  |
+			    |                                        |
+			    ------------------------------------------
+			
+			"LOCAL", "BASE" and "REMOTE" are read-only buffers showing the contents of the
+			conflicting file in a specific git commit ("commit you are merging into",
+			"common ancestor commit" and "commit you are merging from" respectively)
+			
+			"MERGED" is a writable buffer where you have to resolve the conflicts (using the
+			other read-only buffers as a reference). Once you are done, save and exit "vim"
+			as usual (":wq") or, if you want to abort, exit using ":cq".
+			
+			You can change the windows layout used by vim by setting configuration variable
+			"mergetool.vimdiff.layout" which accepts a string where these separators have
+			special meaning:
+			
+			  - ";" is used to "open a new tab"
+			  - "-" is used to "open a new vertical split"
+			  - "|" is used to "open a new horizontal split"
+			
+			Let's see some examples to undertand how it works:
+			
+			  * layout = "(LOCAL | BASE | REMOTE) - MERGED"
+			
+			    This is exactly the same as the default layout we have already seen.
+			
+			  * layout = "LOCAL | MERGED | REMOTE"
+			
+			    If, for some reason, we are not interested in the "BASE" buffer.
+			
+			           ------------------------------------------
+			           |             |           |              |
+			           |             |           |              |
+			           |   LOCAL     |   MERGED  |   REMOTE     |
+			           |             |           |              |
+			           |             |           |              |
+			           ------------------------------------------
+			
+			  * layout = "MERGED"
+			
+			    Only the "MERGED" buffer will be shown. Note, however, that all the other
+			    ones are still loaded in vim, and you can access them with the "buffers"
+			    command. 
+			
+			           ------------------------------------------
+			           |                                        |
+			           |                                        |
+			           |                 MERGED                 |
+			           |                                        |
+			           |                                        |
+			           ------------------------------------------
+			
+			  * layout = "LOCAL* | REMOTE"
+			
+			    When "MERGED" is not present in the layout, you must "mark" one of the
+			    buffers with an asterisk. That will become the buffer you need to edit and
+			    save after resolving the conflicts.
+			
+			           ------------------------------------------
+			           |                   |                    |
+			           |                   |                    |
+			           |                   |                    |
+			           |     LOCAL         |    REMOTE          |
+			           |                   |                    |
+			           |                   |                    |
+			           |                   |                    |
+			           ------------------------------------------
+			
+                          * layout = "(LOCAL | BASE | REMOTE) - MERGED; BASE | LOCAL; BASE | REMOTE"
+			
+			    Three tabs will open: the first one is a copy of the default layout, while
+			    the other two only show the differences between "BASE" and "LOCAL" and
+			    "BASE" and "REMOTE" respectively.
+			 
+			           ------------------------------------------
+			           | <TAB #1> |  TAB #2  |  TAB #3  |       |
+			           ------------------------------------------
+			           |             |           |              |
+			           |   LOCAL     |   BASE    |   REMOTE     |
+			           |             |           |              |
+			           ------------------------------------------
+			           |                                        |
+			           |                MERGED                  |
+			           |                                        |
+			           ------------------------------------------
+			
+			           ------------------------------------------
+			           |  TAB #1  | <TAB #2> |  TAB #3  |       |
+			           ------------------------------------------
+			           |                   |                    |
+			           |                   |                    |
+			           |                   |                    |
+			           |     BASE          |    LOCAL           |
+			           |                   |                    |
+			           |                   |                    |
+			           |                   |                    |
+			           ------------------------------------------
+			
+			           ------------------------------------------
+			           |  TAB #1  |  TAB #2  | <TAB #3> |       |
+			           ------------------------------------------
+			           |                   |                    |
+			           |                   |                    |
+			           |                   |                    |
+			           |     BASE          |    REMOTE          |
+			           |                   |                    |
+			           |                   |                    |
+			           |                   |                    |
+			           ------------------------------------------
+			
+                          * layout = "(LOCAL | BASE | REMOTE) - MERGED; BASE | LOCAL; BASE | REMOTE; (LOCAL - BASE - REMOTE) | MERGED"
+			
+			    Same as the previous example, but adds a fourth tab with the same
+			    information as the first tab, with a different layout.
+			 
+			           ---------------------------------------------
+			           |  TAB #1  |  TAB #2  |  TAB #3  | <TAB #4> |
+			           ---------------------------------------------
+			           |       LOCAL         |                     |
+			           |---------------------|                     |
+			           |       BASE          |        MERGED       |
+			           |---------------------|                     |
+			           |       REMOTE        |                     |
+			           ---------------------------------------------
+
+		ENDOFMESSAGE
+		;;
+	vimdiff1)
+		cat <<-ENDOFMESSAGE
+			Same as 'vimdiff' using this layout: "LOCAL* | REMOTE"
+			
+			This will probably be deprecated in the future. Please use "vimdiff" and
+			manually set the "mergetool.vimdiff.layout" configuration variable instead.
+		ENDOFMESSAGE
+		;;
+	vimdiff2)
+		cat <<-ENDOFMESSAGE
+			Same as 'vimdiff' using this layout: "LOCAL | MERGED | REMOTE"
+			
+			This will probably be deprecated in the future. Please use "vimdiff" and
+			manually set the "mergetool.vimdiff.layout" configuration variable instead.
+		ENDOFMESSAGE
+		;;
+	vimdiff3)
+		cat <<-ENDOFMESSAGE
+			Same as 'vimdiff' using this layout: "MERGED"
+			
+			This will probably be deprecated in the future. Please use "vimdiff" and
+			manually set the "mergetool.vimdiff.layout" configuration variable instead.
+		ENDOFMESSAGE
+		;;
+	gvimdiff)
+		cat <<-ENDOFMESSAGE
+			Same as 'vimdiff' but opens 'gvim' instead (which uses a graphical toolkit for
+			opening its own window).
+			The desired layout can be set with configuration variable
+			"mergetool.gvimdiff.layout"
+		ENDOFMESSAGE
+		;;
+	gvimdiff1)
+		cat <<-ENDOFMESSAGE
+			Same as 'gvimdiff' using this layout: "LOCAL* | REMOTE"
+			
+			This will probably be deprecated in the future. Please use "gvimdiff" and
+			manually set the "mergetool.gvimdiff.layout" configuration variable instead.
+		ENDOFMESSAGE
+		;;
+	gvimdiff2)
+		cat <<-ENDOFMESSAGE
+			Same as 'gvimdiff' using this layout: "LOCAL | MERGED | REMOTE"
+			
+			This will probably be deprecated in the future. Please use "gvimdiff" and
+			manually set the "mergetool.gvimdiff.layout" configuration variable instead.
+		ENDOFMESSAGE
+		;;
+	gvimdiff3)
+		cat <<-ENDOFMESSAGE
+			Same as 'gvimdiff' using this layout: "MERGED"
+			
+			This will probably be deprecated in the future. Please use "gvimdiff" and
+			manually set the "mergetool.gvimdiff.layout" configuration variable instead.
+		ENDOFMESSAGE
+		;;
+	nvimdiff)
+		cat <<-ENDOFMESSAGE
+			Same as 'vimdiff' but opens 'neovim' instead (which is a fork of the original
+			'vim' 'focused on extensibility and usability' according to their authors)
+			The desired layout can be set with configuration variable
+			"mergetool.nvimdiff.layout"
+		ENDOFMESSAGE
+		;;
+	nvimdiff1)
+		cat <<-ENDOFMESSAGE
+			Same as 'nvimdiff' using this layout: "LOCAL* | REMOTE"
+			
+			This will probably be deprecated in the future. Please use "nvimdiff" and
+			manually set the "mergetool.nvimdiff.layout" configuration variable instead.
+		ENDOFMESSAGE
+		;;
+	nvimdiff2)
+		cat <<-ENDOFMESSAGE
+			Same as 'nvimdiff' using this layout: "LOCAL | MERGED | REMOTE"
+			
+			This will probably be deprecated in the future. Please use "nvimdiff" and
+			manually set the "mergetool.nvimdiff.layout" configuration variable instead.
+		ENDOFMESSAGE
+		;;
+	nvimdiff3)
+		cat <<-ENDOFMESSAGE
+			Same as 'nvimdiff' using this layout: "MERGED"
+			
+			This will probably be deprecated in the future. Please use "nvimdiff" and
+			manually set the "mergetool.nvimdiff.layout" configuration variable instead.
+		ENDOFMESSAGE
+		;;
+	esac
+
+	return 0
+}
+
 
 translate_merge_tool_path() {
 	case "$1" in
-- 
2.33.1


  parent reply	other threads:[~2021-11-04 16:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-04 16:09 [PATCH 0/3] vimdiff: new layout option + docs Fernando Ramos
2021-11-04 16:09 ` [PATCH 1/3] vimdiff: new implementation with layout support Fernando Ramos
2021-11-07 22:41   ` David Aguilar
2021-11-08  0:47     ` Eric Sunshine
2021-11-04 16:09 ` Fernando Ramos [this message]
2021-11-07 21:24   ` [PATCH 2/3] vimdiff: add tool documentation David Aguilar
2021-11-08  1:02     ` Eric Sunshine
2021-11-08 19:08     ` Junio C Hamano
2021-11-04 16:09 ` [PATCH 3/3] vimdiff: remove deprecated {,g,n}vimdiff{1,2,3} variants Fernando Ramos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211104160959.183402-3-greenfoo@u92.eu \
    --to=greenfoo@u92.eu \
    --cc=davvid@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=levraiphilippeblain@gmail.com \
    --cc=rogi@skylittlesystem.org \
    --cc=seth@eseth.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).