From: Pratyush Yadav <me@yadavpratyush.com>
To: Sashank Bandi <bandi.rao999@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Bagas Sanjaya <bagasdotme@gmail.com>,
David Aguilar <davvid@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [INFO] Does Git GUI support Dark Mode on Windows 10 ?
Date: Wed, 6 Oct 2021 17:09:12 +0530 [thread overview]
Message-ID: <20211006113912.n7xpnuzd25256cjm@yadavpratyush.com> (raw)
In-Reply-To: <CABkJDHGdzOFW5yP43LZtuUrV7WsDTvAi+kxka84-5P7ShbV9FQ@mail.gmail.com>
On 04/10/21 08:39PM, Sashank Bandi wrote:
> On Mon, Oct 4, 2021 at 1:26 PM Pratyush Yadav <me@yadavpratyush.com> wrote:
> > Sorry, I couldn't find time to catch up on this because its been busy at
> > $DAYJOB.
> Well, I hope you got a little time for this thread.
>
> > Anyway, git-gui does have some basic dark mode support, though I have
> > seen reports that it does not work very well. You can change the Tk
> > theme and it should enable dark mode on git-gui as well. See [0] for
> > some more info. I am not very familiar with how Tk theming would work on
> > Windows.
> I am not even familiar with Tcl/Tk language itself. But from what I
> have found, the Tk uses "vista" theme which is Windows-only default
> theme.
Does the Windows installation come with any other themes? You can use
`ttk::style theme names` to list all available themes.
>
> > I think it would be nice if we can have a theme picker in the options
> > menu though, so that is something you might want to look into.
> Yes, I thought of adding a menu between "Tools" and "Help". It will
> contain 3 options(system, light, dark) as I said before.
I think it would be better to put it in the "options" dialog.
>
> > [0] https://lore.kernel.org/all/20201008082004.5643-1-serg.partizan@gmail.com/
> Well, this works only for Linux as Windows doesn't use X Server. But
> we can use `ttk::style theme use` for it all over the application.
Right.
>
> My plan is to use a new theme, that is based on default, but can
> imitate the look of [0].
I don't mind carrying themes in the git-gui repo since Tk theming
support is not very well documented or standardized. But please do be
careful of licence compatibility when porting code.
>
> [0]: https://github.com/TkinterEP/ttkthemes/blob/master/ttkthemes/png/equilux/equilux.tcl
--
Regards,
Pratyush Yadav
next prev parent reply other threads:[~2021-10-06 11:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-26 15:09 [INFO] Does Git GUI support Dark Mode on Windows 10 ? Sashank Bandi
2021-09-27 6:32 ` Bagas Sanjaya
2021-09-27 10:19 ` Sashank Bandi
2021-09-27 10:39 ` Bagas Sanjaya
2021-09-27 10:51 ` Sashank Bandi
2021-09-27 18:08 ` David Aguilar
2021-09-28 3:21 ` Sashank Bandi
2021-10-03 14:33 ` Sashank Bandi
2021-10-04 3:29 ` Bagas Sanjaya
2021-10-04 7:56 ` Pratyush Yadav
2021-10-04 15:09 ` Sashank Bandi
2021-10-06 11:39 ` Pratyush Yadav [this message]
2021-10-06 14:45 ` Sashank Bandi
2021-10-06 18:03 ` Pratyush Yadav
2021-10-07 11:27 ` Sashank Bandi
-- strict thread matches above, loose matches on Subject: below --
2021-12-08 12:29 Birger Skogeng Pedersen
2021-12-13 8:03 Birger Skogeng Pedersen
2021-12-21 16:14 ` Sashank Bandi
2022-01-17 14:33 ` Birger Skogeng Pedersen
2022-01-17 14:40 ` Birger Skogeng Pedersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211006113912.n7xpnuzd25256cjm@yadavpratyush.com \
--to=me@yadavpratyush.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=bagasdotme@gmail.com \
--cc=bandi.rao999@gmail.com \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).