From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id F2D831F8C8 for ; Wed, 6 Oct 2021 11:39:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238524AbhJFLlJ (ORCPT ); Wed, 6 Oct 2021 07:41:09 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:48713 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238201AbhJFLlI (ORCPT ); Wed, 6 Oct 2021 07:41:08 -0400 Received: (Authenticated sender: me@yadavpratyush.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id D04CC40003; Wed, 6 Oct 2021 11:39:14 +0000 (UTC) Date: Wed, 6 Oct 2021 17:09:12 +0530 From: Pratyush Yadav To: Sashank Bandi Cc: Git Mailing List , Bagas Sanjaya , David Aguilar , Johannes Schindelin Subject: Re: [INFO] Does Git GUI support Dark Mode on Windows 10 ? Message-ID: <20211006113912.n7xpnuzd25256cjm@yadavpratyush.com> References: <7b4b59a4-7e58-3db2-d934-d570cdebbf31@gmail.com> <135f854b-7975-a6a0-69ea-8697583a87b2@gmail.com> <20211004075600.5lbqed4mnwfsy4al@yadavpratyush.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 04/10/21 08:39PM, Sashank Bandi wrote: > On Mon, Oct 4, 2021 at 1:26 PM Pratyush Yadav wrote: > > Sorry, I couldn't find time to catch up on this because its been busy at > > $DAYJOB. > Well, I hope you got a little time for this thread. > > > Anyway, git-gui does have some basic dark mode support, though I have > > seen reports that it does not work very well. You can change the Tk > > theme and it should enable dark mode on git-gui as well. See [0] for > > some more info. I am not very familiar with how Tk theming would work on > > Windows. > I am not even familiar with Tcl/Tk language itself. But from what I > have found, the Tk uses "vista" theme which is Windows-only default > theme. Does the Windows installation come with any other themes? You can use `ttk::style theme names` to list all available themes. > > > I think it would be nice if we can have a theme picker in the options > > menu though, so that is something you might want to look into. > Yes, I thought of adding a menu between "Tools" and "Help". It will > contain 3 options(system, light, dark) as I said before. I think it would be better to put it in the "options" dialog. > > > [0] https://lore.kernel.org/all/20201008082004.5643-1-serg.partizan@gmail.com/ > Well, this works only for Linux as Windows doesn't use X Server. But > we can use `ttk::style theme use` for it all over the application. Right. > > My plan is to use a new theme, that is based on default, but can > imitate the look of [0]. I don't mind carrying themes in the git-gui repo since Tk theming support is not very well documented or standardized. But please do be careful of licence compatibility when porting code. > > [0]: https://github.com/TkinterEP/ttkthemes/blob/master/ttkthemes/png/equilux/equilux.tcl -- Regards, Pratyush Yadav