From: Jonathan Tan <jonathantanmy@google.com>
To: newren@gmail.com
Cc: gitster@pobox.com, git@vger.kernel.org, jonathantanmy@google.com
Subject: Re: What's cooking in git.git (Aug 2021, #03; Fri, 6)
Date: Tue, 10 Aug 2021 15:38:59 -0700 [thread overview]
Message-ID: <20210810223859.2820306-1-jonathantanmy@google.com> (raw)
In-Reply-To: <CABPp-BFOusrK6E6n91XSXcKP8kin-8RX8L_HXdKRjS790HkwHQ@mail.gmail.com>
> I'm not at all familiar with the protocol areas of the code, but I
> tried to read over the patches too. I think it'd have been a bit
> easier to understand for someone unfamiliar with this area if there
> were separate patches that introduced test_expect_failure showing the
> particular failures being fixed, followed by fixes in subsequent
> patches. I also noticed a stray newline removal in patch 2. Those
> are pretty minor issues, though, and I didn't spot anything
> substantial.
Thanks Elijah and everyone else for discussing. I don't think I have
anything to add to the discussion, but just to address this part, I do
try to write my patches in such a way that in each patch, if a test is
included, it would fail if the accompanying code change in that patch
did not exist. Just in case, I've verified this with my branch by
splitting out the tests and code into their own commits, and pushed it
onto GitHub [1]. The tip points to the exact same tree as
jt/push-negotiation-fixes.
[1] https://github.com/jonathantanmy/git/commits/push-negotiation-fixes-split
prev parent reply other threads:[~2021-08-10 22:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-07 0:17 What's cooking in git.git (Aug 2021, #03; Fri, 6) Junio C Hamano
2021-08-07 15:53 ` Elijah Newren
2021-08-09 15:27 ` Junio C Hamano
2021-08-07 16:29 ` Elijah Newren
2021-08-09 17:17 ` Junio C Hamano
2021-08-09 18:39 ` Elijah Newren
2021-08-09 18:42 ` Jeff King
2021-08-10 22:38 ` Jonathan Tan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210810223859.2820306-1-jonathantanmy@google.com \
--to=jonathantanmy@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).