From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Daniel Duvall <dan@mutual.io>, Git Users <git@vger.kernel.org>
Subject: Re: [PATCH] upload-pack: allow stateless client EOF just prior to haves
Date: Wed, 4 Nov 2020 08:33:42 -0500 [thread overview]
Message-ID: <20201104133342.GB3030480@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqeelaqh7m.fsf@gitster.c.googlers.com>
On Tue, Nov 03, 2020 at 01:10:53PM -0800, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > I'm still uncertain whether it could all be done in one request for v0.
> > But one possible solution is: let's not care. If v2 does it correctly,
> > that's the future anyway (or present; it's now the default in v2.29).
> > And the change you're proposing in upload-pack would be desirable anyway
> > to help deal with older clients.
> >
> > If that's the route we go, we should make sure the commit message
> > explains it.
>
> Yeah, I'd agree that punting on v0 and making sure the current
> version would work well is good enough.
>
> I lost track and am not sure what's the current status of the topic
> is. Is v3 [*1*] the latest and satisfactory one?
Yeah, I just read over v3 again and it looks good to me. Thanks, Daniel!
-Peff
next prev parent reply other threads:[~2020-11-04 13:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 1:40 [PATCH] upload-pack: allow stateless client EOF just prior to haves Daniel Duvall
2020-10-30 2:59 ` Eric Sunshine
2020-10-30 3:31 ` Daniel Duvall
2020-10-30 3:43 ` Daniel Duvall
2020-10-30 18:42 ` Junio C Hamano
2020-10-30 22:38 ` Daniel Duvall
2020-10-30 4:40 ` Jeff King
2020-10-30 7:47 ` Daniel Duvall
2020-10-30 9:09 ` Jeff King
2020-11-03 21:10 ` Junio C Hamano
2020-11-04 13:33 ` Jeff King [this message]
2020-11-04 14:06 ` Daniel Duvall
2020-11-04 18:25 ` Junio C Hamano
2020-10-30 22:35 ` [PATCH v2] " Daniel Duvall
2020-10-30 23:45 ` Junio C Hamano
2020-10-31 2:42 ` Daniel Duvall
2020-10-31 4:17 ` Junio C Hamano
2020-10-31 2:39 ` [PATCH v3] " Daniel Duvall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104133342.GB3030480@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=dan@mutual.io \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).