From: Daniel Duvall <dan@mutual.io>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Users <git@vger.kernel.org>
Subject: Re: [PATCH v2] upload-pack: allow stateless client EOF just prior to haves
Date: Fri, 30 Oct 2020 19:42:27 -0700 [thread overview]
Message-ID: <CANo+1guedZiZVbnANsSPCiYbKWpJ_tjJ7vc04Ap7EVZzzp869A@mail.gmail.com> (raw)
In-Reply-To: <xmqqzh4346sb.fsf@gitster.c.googlers.com>
On Fri, Oct 30, 2020 at 4:45 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> > t/t5705-upload-pack-stateless-shallow-eof.sh | 24 ++++++++++++++++++++
> > upload-pack.c | 13 ++++++++++-
> > 2 files changed, 36 insertions(+), 1 deletion(-)
> > create mode 100755 t/t5705-upload-pack-stateless-shallow-eof.sh
>
> I'd rather see it folded in an existing test, if it makes sense.
With v3 I've moved it into t/t5530-upload-pack-error.sh. That test
file seemed to mostly contain errant cases, but I thought it might be
close enough as this was previously an errant case. If there's a
better place for it I'm happy to move it again.
next prev parent reply other threads:[~2020-10-31 2:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 1:40 [PATCH] upload-pack: allow stateless client EOF just prior to haves Daniel Duvall
2020-10-30 2:59 ` Eric Sunshine
2020-10-30 3:31 ` Daniel Duvall
2020-10-30 3:43 ` Daniel Duvall
2020-10-30 18:42 ` Junio C Hamano
2020-10-30 22:38 ` Daniel Duvall
2020-10-30 4:40 ` Jeff King
2020-10-30 7:47 ` Daniel Duvall
2020-10-30 9:09 ` Jeff King
2020-11-03 21:10 ` Junio C Hamano
2020-11-04 13:33 ` Jeff King
2020-11-04 14:06 ` Daniel Duvall
2020-11-04 18:25 ` Junio C Hamano
2020-10-30 22:35 ` [PATCH v2] " Daniel Duvall
2020-10-30 23:45 ` Junio C Hamano
2020-10-31 2:42 ` Daniel Duvall [this message]
2020-10-31 4:17 ` Junio C Hamano
2020-10-31 2:39 ` [PATCH v3] " Daniel Duvall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANo+1guedZiZVbnANsSPCiYbKWpJ_tjJ7vc04Ap7EVZzzp869A@mail.gmail.com \
--to=dan@mutual.io \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).