From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Bryan Turner <bturner@atlassian.com>, Git Users <git@vger.kernel.org>
Subject: Re: Mismatched HEAD default behavior from git log
Date: Tue, 25 Aug 2020 15:55:11 -0400 [thread overview]
Message-ID: <20200825195511.GD1419759@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqq4koq1p28.fsf@gitster.c.googlers.com>
On Tue, Aug 25, 2020 at 12:51:59PM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> >> As the intent for adding the "--stdin" option to any subcommand has
> >> always been "we may need to feed many many things, that may bust the
> >> command line length limit, hence we let you feed these things from
> >> the standard input, but otherwise there should be no change in
> >> behaviour or semantics", when the behaviour of command line and
> >> "--stdin" differ, it is a bug in the latter.
> >
> > Agreed. It also helps in this case that the command-line behavior is
> > sensible and the --stdin one is not. :)
> >
> > I think the solution is probably something like:
>
> You beat me to it while I was wondering what to do between the local
> got_rev_arg variable and the revs->rev_input_given field.
That makes me wonder why we need got_rev_arg at all if we have
revs->rev_input_given. But I suspect an answer can be found by digging
into git-blame. I probably won't do that immediately, so if you want to,
you can do so without worrying that we're duplicating work. :)
-Peff
next prev parent reply other threads:[~2020-08-25 19:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 19:16 Mismatched HEAD default behavior from git log Bryan Turner
2020-08-25 19:40 ` Junio C Hamano
2020-08-25 19:46 ` Jeff King
2020-08-25 19:51 ` Junio C Hamano
2020-08-25 19:55 ` Jeff King [this message]
2020-08-26 20:13 ` [PATCH] revision: set rev_input_given in handle_revision_arg() Jeff King
2020-08-26 20:20 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825195511.GD1419759@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=bturner@atlassian.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).