From: Shourya Shukla <shouryashukla.oo@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, christian.couder@gmail.com,
kaartic.sivaraam@gmail.com, Johannes.Schindelin@gmx.de,
peff@peff.net, liu.denton@gmail.com,
Shourya Shukla <shouryashukla.oo@gmail.com>
Subject: [GSoC][PATCH 0/3] submodule: fixup to summary-v3
Date: Tue, 25 Aug 2020 17:00:17 +0530 [thread overview]
Message-ID: <20200825113020.71801-1-shouryashukla.oo@gmail.com> (raw)
Greetings,
The v3 of 'git submodule summary' port to C is currently in 'next'
branch of git/git. Recently, the patch recieved some comments from
Peff, Dscho and Kaartic:
1. The definition of 'print_submodule_summary()' contained two
unused parameters namely 'missing_src' and 'missing_dst'. Hence,
I had to eliminate them as covered in the commit a22ffa950f
a22ffa950f (submodule: eliminate unused parameters from
print_submodule_summary(), 2020-08-21). Reported by Peff.
Junio also advised to make the output in case of an unexpected
file mode a bit more user friendly by outputting an octal instead
of a decimal.
2. The function definitions of 'verify_submodule_committish()' and
'print_submodule_summary()' had wrong styling in terms of the
asterisk placement. Hence it was fixed in 32934998ee (submodule:
fix style in function definition, 2020-08-22). Reported by
Kaartic.
2. The test script 't7421-submodule-summary-add.sh' failed in
Windows due to failure of t7421.4. Precisely, the 'test_i18ngrep'
check failed on Windows since the error message which was being
grepped was different on Windows; it was designed to work on
Linux. Therefore, we had to eliminate the grep check in t7421.4
and replace it with a check to see if there is any error message
or not using 'test_must_be_empty'. Also, to support this change,
we had to make some small changes in 'print_submodule_summary()'
function. The call to verify_submodule_committish()' had to be
guarded using 'p->status !=D' so that it isn't called when the SM
directory does not exist, therefore, the error message is not
displayed. This resulted in 82e0956cd2 (t7421: eliminate 'grep'
check in t7421.4 for mingw compatibility, 2020-08-22). Reported
by Dscho.
summary-v3: https://lore.kernel.org/git/20200812194404.17028-1-shouryashukla.oo@gmail.com/
Peff's comment: https://lore.kernel.org/git/20200818020838.GA1872632@coredump.intra.peff.net/
Dscho' comment: https://lore.kernel.org/git/nycvar.QRO.7.76.6.2008211708280.56@tvgsbejvaqbjf.bet/
Kaartic's comment: https://lore.kernel.org/git/377b1a2ad60c5ca30864f48c5921ff89b5aca65b.camel@gmail.com/
Junio's comment regarding unexpected file mode: https://lore.kernel.org/git/xmqqo8n053r6.fsf@gitster.c.googlers.com/
Feedback and reviews are appreciated.
Regards,
Shourya Shukla
Shourya Shukla (3):
submodule: eliminate unused parameters from print_submodule_summary()
submodule: fix style in function definition
t7421: eliminate 'grep' check in t7421.4 for mingw compatibility
builtin/submodule--helper.c | 17 ++++++++---------
t/t7421-submodule-summary-add.sh | 2 +-
2 files changed, 9 insertions(+), 10 deletions(-)
--
2.28.0
next reply other threads:[~2020-08-25 11:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 11:30 Shourya Shukla [this message]
2020-08-25 11:30 ` [PATCH 1/3] submodule: eliminate unused parameters from print_submodule_summary() Shourya Shukla
2020-08-25 11:30 ` [PATCH 2/3] submodule: fix style in function definition Shourya Shukla
2020-08-25 20:45 ` Junio C Hamano
2020-08-26 9:45 ` Shourya Shukla
2020-08-26 16:47 ` Junio C Hamano
2020-08-25 11:30 ` [PATCH 3/3] t7421: eliminate 'grep' check in t7421.4 for mingw compatibility Shourya Shukla
2020-08-25 14:33 ` Kaartic Sivaraam
2020-08-25 16:10 ` Junio C Hamano
2020-08-27 9:14 ` Shourya Shukla
2020-08-26 10:40 ` Shourya Shukla
2020-08-25 14:38 ` [GSoC][PATCH 0/3] submodule: fixup to summary-v3 Kaartic Sivaraam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825113020.71801-1-shouryashukla.oo@gmail.com \
--to=shouryashukla.oo@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kaartic.sivaraam@gmail.com \
--cc=liu.denton@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).