From: Junio C Hamano <gitster@pobox.com>
To: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Cc: Shourya Shukla <shouryashukla.oo@gmail.com>,
git@vger.kernel.org, christian.couder@gmail.com,
Johannes.Schindelin@gmx.de, peff@peff.net, liu.denton@gmail.com,
Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH 3/3] t7421: eliminate 'grep' check in t7421.4 for mingw compatibility
Date: Tue, 25 Aug 2020 09:10:35 -0700 [thread overview]
Message-ID: <xmqqlfi21zb8.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <2a1ea501-4974-4d74-fe3c-d173bbe76855@gmail.com> (Kaartic Sivaraam's message of "Tue, 25 Aug 2020 20:03:24 +0530")
Kaartic Sivaraam <kaartic.sivaraam@gmail.com> writes:
>> @@ -1061,8 +1061,9 @@ static void generate_submodule_summary(struct summary_cb *info,
>> }
>>
>> if (S_ISGITLINK(p->mod_src)) {
>> - src_abbrev = verify_submodule_committish(p->sm_path,
>> - oid_to_hex(&p->oid_src));
>> + if (p->status != 'D')
>> + src_abbrev = verify_submodule_committish(p->sm_path,
>> + oid_to_hex(&p->oid_src));
>> if (!src_abbrev) {
>> missing_src = 1;
>> /*
Interesting. There is a mirroring if-else cascade that begins with
"if (S_ISGITLINK(p->mod_dst))" immediately after the if-else cascade
started here, and in there, the same verify_submodule_committish()
is called for oid_dst unconditionally. Should the asymmetry bother
readers of the code, or is the source side somehow special and needs
extra care?
next prev parent reply other threads:[~2020-08-25 16:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 11:30 [GSoC][PATCH 0/3] submodule: fixup to summary-v3 Shourya Shukla
2020-08-25 11:30 ` [PATCH 1/3] submodule: eliminate unused parameters from print_submodule_summary() Shourya Shukla
2020-08-25 11:30 ` [PATCH 2/3] submodule: fix style in function definition Shourya Shukla
2020-08-25 20:45 ` Junio C Hamano
2020-08-26 9:45 ` Shourya Shukla
2020-08-26 16:47 ` Junio C Hamano
2020-08-25 11:30 ` [PATCH 3/3] t7421: eliminate 'grep' check in t7421.4 for mingw compatibility Shourya Shukla
2020-08-25 14:33 ` Kaartic Sivaraam
2020-08-25 16:10 ` Junio C Hamano [this message]
2020-08-27 9:14 ` Shourya Shukla
2020-08-26 10:40 ` Shourya Shukla
2020-08-25 14:38 ` [GSoC][PATCH 0/3] submodule: fixup to summary-v3 Kaartic Sivaraam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlfi21zb8.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=kaartic.sivaraam@gmail.com \
--cc=liu.denton@gmail.com \
--cc=peff@peff.net \
--cc=shouryashukla.oo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).