From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Patrick Steinhardt <ps@pks.im>,
git@vger.kernel.org, Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH] refs: remove lookup cache for reference-transaction hook
Date: Fri, 21 Aug 2020 13:21:37 -0400 [thread overview]
Message-ID: <20200821172137.GA3261095@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqeeo09chm.fsf@gitster.c.googlers.com>
On Fri, Aug 21, 2020 at 09:42:45AM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > However, I wondered...
> >
> >> +test_perf "nonatomic push" '
> >> + git push ./target-repo.git branch-{1..1000} &&
> >> + git push --delete ./target-repo.git branch-{1..1000}
> >> +'
>
> Is this a bash-and-ksh-only test? At least, the above would not try
> to push 1000 branches with the version of dash I have.
Heh, I was so focused on the "push" part of it that I didn't even look
carefully at the second half of the command-line. ;)
I think pushing "refs/heads/branch-*" would work for pushing. For
deletion, though, I don't think we allow wildcards in the refspecs.
You could abuse pruning:
git push --prune ../dst.git refs/heads/does-not-exist/*:refs/heads/*
It also may be OK to just omit that half of the test. I think the
initial push exercises the case we care about. Though I guess we do run
the test repeatedly, so we might have to do:
rm -rf dst.git &&
git init dst.git &&
git push dst.git refs/heads/branch-*
-Peff
next prev parent reply other threads:[~2020-08-21 17:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 8:29 [PATCH] refs: remove lookup cache for reference-transaction hook Patrick Steinhardt
2020-08-21 14:37 ` Jeff King
2020-08-21 16:42 ` Junio C Hamano
2020-08-21 17:21 ` Jeff King [this message]
2020-08-22 9:02 ` Patrick Steinhardt
2020-08-22 8:59 ` Patrick Steinhardt
2020-08-25 10:35 ` [PATCH v2] " Patrick Steinhardt
2020-08-25 15:10 ` Jeff King
2020-08-25 18:09 ` Junio C Hamano
2020-08-25 18:29 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200821172137.GA3261095@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).