From: Jeff King <peff@peff.net>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH v2] refs: remove lookup cache for reference-transaction hook
Date: Tue, 25 Aug 2020 11:10:53 -0400 [thread overview]
Message-ID: <20200825151053.GA1409139@coredump.intra.peff.net> (raw)
In-Reply-To: <c1cae6dd19ffe00e4456e4f96ad92277ceeced27.1598349284.git.ps@pks.im>
On Tue, Aug 25, 2020 at 12:35:24PM +0200, Patrick Steinhardt wrote:
> The only change compared to v1 is that I've addressed the unportable
> `branch-{1..1000}` syntax in favor of `test_seq`. I had to setup refs as
> part of the setup and change the ordering for "update-ref --stdin" from
> create/update/delete to update/delete/create, but I don't think that's
> too bad. At least timings didn't seem to really change because of that.
Another option instead of changing the order in the other tests is to do
another untimed setup step before the push test. I'm OK either way,
though.
> +test_perf "nonatomic push" '
> + git push ./target-repo.git $(test_seq 1000) &&
> + git push --delete ./target-repo.git $(test_seq 1000)
> '
This works as far as Git is concerned, but "seq 1000" output with NULs
is 3893 bytes. I wonder if some platforms might run into command-line
limits there. I guess we will see when Windows CI runs. :)
-Peff
next prev parent reply other threads:[~2020-08-25 15:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 8:29 [PATCH] refs: remove lookup cache for reference-transaction hook Patrick Steinhardt
2020-08-21 14:37 ` Jeff King
2020-08-21 16:42 ` Junio C Hamano
2020-08-21 17:21 ` Jeff King
2020-08-22 9:02 ` Patrick Steinhardt
2020-08-22 8:59 ` Patrick Steinhardt
2020-08-25 10:35 ` [PATCH v2] " Patrick Steinhardt
2020-08-25 15:10 ` Jeff King [this message]
2020-08-25 18:09 ` Junio C Hamano
2020-08-25 18:29 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825151053.GA1409139@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).