From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 10/11] strvec: drop argv_array compatibility layer
Date: Tue, 28 Jul 2020 20:04:30 -0400 [thread overview]
Message-ID: <20200729000430.GA1623001@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqq5za7cm8e.fsf@gitster.c.googlers.com>
On Tue, Jul 28, 2020 at 03:23:45PM -0700, Junio C Hamano wrote:
> It was more painful than I would have thought to merge this topic,
> as we seem to have gained quite a few new calling sites (it shows
> how popular and useful this API is). Hopefully some of the merge
> conflict resolutions would be resurrected automatically from the
> rerere database ;-)
I'm not too surprised; it made a little chaos with my personal topics,
too. I'm happy to help with resolutions, but it looks like you've
already merged it to "seen", which means the worst of it is mostly over.
I did specifically wait on it until until after a release, but I think
we pretty much always have topics in flight these days. There is no
quiet time. :)
If I swap out the final patch with "s/items/v/" that may cause a
_little_ more trouble, but perhaps not quite as much (only some of the
sites access the fields directly).
-Peff
next prev parent reply other threads:[~2020-07-29 0:05 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 20:21 [PATCH 0/11] renaming argv_array Jeff King
2020-07-28 20:21 ` [PATCH 01/11] argv-array: use size_t for count and alloc Jeff King
2020-07-28 20:23 ` [PATCH 02/11] argv-array: rename to strvec Jeff King
2020-07-28 20:23 ` [PATCH 03/11] strvec: rename files from argv-array " Jeff King
2020-07-28 20:24 ` [PATCH 04/11] quote: rename sq_dequote_to_argv_array to mention strvec Jeff King
2020-07-28 20:24 ` [PATCH 05/11] strvec: convert builtin/ callers away from argv_array name Jeff King
2020-07-28 20:24 ` [PATCH 06/11] strvec: convert more " Jeff King
2020-07-28 20:25 ` [PATCH 07/11] strvec: convert remaining " Jeff King
2020-07-28 20:26 ` [PATCH 08/11] strvec: fix indentation in renamed calls Jeff King
2020-07-28 22:43 ` Jacob Keller
2020-07-28 23:31 ` Junio C Hamano
2020-07-28 20:26 ` [PATCH 09/11] strvec: update documention to avoid argv_array Jeff King
2020-07-28 20:27 ` [PATCH 10/11] strvec: drop argv_array compatibility layer Jeff King
2020-07-28 22:23 ` Junio C Hamano
2020-07-29 0:04 ` Jeff King [this message]
2020-07-29 0:37 ` Jeff King
2020-07-29 0:40 ` Jeff King
2020-07-29 0:47 ` Junio C Hamano
2020-07-29 16:54 ` Derrick Stolee
2020-07-29 0:44 ` Junio C Hamano
2020-07-29 16:22 ` Jeff King
2020-07-28 20:28 ` [PATCH 11/11] strvec: rename struct fields Jeff King
2020-07-28 21:16 ` Junio C Hamano
2020-07-28 21:18 ` Junio C Hamano
2020-07-29 6:55 ` Christian Couder
2020-07-29 16:34 ` Jeff King
2020-07-29 18:03 ` Junio C Hamano
2020-07-28 21:20 ` Jeff King
2020-07-28 22:45 ` [PATCH 0/11] renaming argv_array Jacob Keller
2020-07-29 0:06 ` Jeff King
2020-07-29 6:15 ` Christian Couder
2020-07-29 6:19 ` Christian Couder
2020-07-29 13:32 ` Eric Sunshine
2020-07-29 16:33 ` Jeff King
2020-08-11 16:08 ` René Scharfe
2020-08-11 18:28 ` Taylor Blau
2020-08-11 19:00 ` Junio C Hamano
2020-08-11 20:39 ` Jacob Keller
2020-08-11 21:03 ` Junio C Hamano
2020-08-12 12:42 ` Johannes Schindelin
2020-08-12 15:06 ` Jeff King
2020-08-12 15:10 ` Jeff King
2020-08-12 16:23 ` René Scharfe
2020-08-12 17:08 ` Jeff King
2020-08-12 18:18 ` René Scharfe
2020-08-12 19:57 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729000430.GA1623001@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).