From: Jeff King <peff@peff.net>
To: "René Scharfe" <l.s.r@web.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/11] renaming argv_array
Date: Wed, 12 Aug 2020 15:57:03 -0400 [thread overview]
Message-ID: <20200812195703.GA1340519@coredump.intra.peff.net> (raw)
In-Reply-To: <13d0b147-3c62-5d73-630e-2305c08c3ab1@web.de>
On Wed, Aug 12, 2020 at 08:18:33PM +0200, René Scharfe wrote:
> Am 12.08.20 um 19:08 schrieb Jeff King:
> > Yeah, I've had various issues with the packaging. For a long time they
> > had 1.0.7 in experimental, but with no python support. I wonder if it's
> > worth starting to use python scriptlets in our coccinelle rules, as
> > described in 4d168e742a (coccinelle: use <...> for function exclusion,
> > 2018-08-28). They're faster and IMHO easier to understand.
>
> The idea to use Python as a faster alternative to anything makes me
> a bit uneasy. That can't be right. ;-)
Well, when you're comparing it to some exponential algorithm with the
other technique, even a scripted language can do well. :)
I definitely remember getting big speedups back at the time of that
commit. But applying the patch below, building object_id.cocci.patch
actually gets a few seconds slower. So maybe something changed between
the various coccinelle versions. At any rate, it doesn't seem worth
pursuing further.
> > Of course I tried it out and got some inscrutable errors:
> >
> > SPATCH contrib/coccinelle/object_id.cocci
> > init_defs_builtins: /usr/bin/../lib/coccinelle/standard.h
> > Python path configuration:
> > PYTHONHOME = '/lib/x86_64-linux-gnu/..'
>
> This looks bogus. Can you try to unset this environment variable?
> Or set it to "/usr"?
It's not set in my environment. However, I was able to solve it by
fiddling with my system python packages (I'm not sure of the exact
cause; it was a case of corrected-while-testing).
-Peff
prev parent reply other threads:[~2020-08-12 19:57 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 20:21 [PATCH 0/11] renaming argv_array Jeff King
2020-07-28 20:21 ` [PATCH 01/11] argv-array: use size_t for count and alloc Jeff King
2020-07-28 20:23 ` [PATCH 02/11] argv-array: rename to strvec Jeff King
2020-07-28 20:23 ` [PATCH 03/11] strvec: rename files from argv-array " Jeff King
2020-07-28 20:24 ` [PATCH 04/11] quote: rename sq_dequote_to_argv_array to mention strvec Jeff King
2020-07-28 20:24 ` [PATCH 05/11] strvec: convert builtin/ callers away from argv_array name Jeff King
2020-07-28 20:24 ` [PATCH 06/11] strvec: convert more " Jeff King
2020-07-28 20:25 ` [PATCH 07/11] strvec: convert remaining " Jeff King
2020-07-28 20:26 ` [PATCH 08/11] strvec: fix indentation in renamed calls Jeff King
2020-07-28 22:43 ` Jacob Keller
2020-07-28 23:31 ` Junio C Hamano
2020-07-28 20:26 ` [PATCH 09/11] strvec: update documention to avoid argv_array Jeff King
2020-07-28 20:27 ` [PATCH 10/11] strvec: drop argv_array compatibility layer Jeff King
2020-07-28 22:23 ` Junio C Hamano
2020-07-29 0:04 ` Jeff King
2020-07-29 0:37 ` Jeff King
2020-07-29 0:40 ` Jeff King
2020-07-29 0:47 ` Junio C Hamano
2020-07-29 16:54 ` Derrick Stolee
2020-07-29 0:44 ` Junio C Hamano
2020-07-29 16:22 ` Jeff King
2020-07-28 20:28 ` [PATCH 11/11] strvec: rename struct fields Jeff King
2020-07-28 21:16 ` Junio C Hamano
2020-07-28 21:18 ` Junio C Hamano
2020-07-29 6:55 ` Christian Couder
2020-07-29 16:34 ` Jeff King
2020-07-29 18:03 ` Junio C Hamano
2020-07-28 21:20 ` Jeff King
2020-07-28 22:45 ` [PATCH 0/11] renaming argv_array Jacob Keller
2020-07-29 0:06 ` Jeff King
2020-07-29 6:15 ` Christian Couder
2020-07-29 6:19 ` Christian Couder
2020-07-29 13:32 ` Eric Sunshine
2020-07-29 16:33 ` Jeff King
2020-08-11 16:08 ` René Scharfe
2020-08-11 18:28 ` Taylor Blau
2020-08-11 19:00 ` Junio C Hamano
2020-08-11 20:39 ` Jacob Keller
2020-08-11 21:03 ` Junio C Hamano
2020-08-12 12:42 ` Johannes Schindelin
2020-08-12 15:06 ` Jeff King
2020-08-12 15:10 ` Jeff King
2020-08-12 16:23 ` René Scharfe
2020-08-12 17:08 ` Jeff King
2020-08-12 18:18 ` René Scharfe
2020-08-12 19:57 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200812195703.GA1340519@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).