From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
git@vger.kernel.org, Derrick Stolee <dstolee@microsoft.com>
Subject: Re: Protocol v2 in v2.27 (Re: Re* [ANNOUNCE] Git v2.27.0-rc1)
Date: Wed, 20 May 2020 20:29:06 -0400 [thread overview]
Message-ID: <20200521002906.GA1273723@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqlflmtaxq.fsf@gitster.c.googlers.com>
On Wed, May 20, 2020 at 04:59:29PM -0700, Junio C Hamano wrote:
> Jonathan Nieder <jrnieder@gmail.com> writes:
>
> > Speaking of which, should we enable protocol v2 by default for people
> > with feature.experimental enabled, like this?
>
> It is an excellent idea, but is something that had to have been
> proposed before -rc0 to be in the upcoming release, no?
Yeah, my original email was almost "hey, did we make a conscious
decision to keep v2 reverted after we found the root cause?". But I
think it is too late in the -rc cycle to switch now (which is kind of a
shame, because we won't really get good data on whether the in_vain fix
helped the Linux folks, since it seems clear that most of them are not
switching protocol.version themselves).
The feature.experimental one we could be a bit more cavalier with,
though. I dunno.
(I guess you could argue that since v2.26.2 shipped with protocol v2, we
could already be pretty cavalier with _leaving_ it on in the new
release, but I think as a general principle -rc2 is not the right time
to go flipping defaults).
-Peff
next prev parent reply other threads:[~2020-05-21 0:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 19:17 [ANNOUNCE] Git v2.27.0-rc1 Junio C Hamano
2020-05-20 19:31 ` Jeff King
2020-05-20 20:02 ` Junio C Hamano
2020-05-20 20:31 ` Re* " Junio C Hamano
2020-05-20 21:24 ` Jeff King
2020-05-20 22:00 ` Protocol v2 in v2.27 (Re: Re* [ANNOUNCE] Git v2.27.0-rc1) Jonathan Nieder
2020-05-20 23:59 ` Junio C Hamano
2020-05-21 0:29 ` Jeff King [this message]
2020-05-21 2:15 ` Jonathan Nieder
2020-05-21 2:35 ` Carlo Marcelo Arenas Belón
2020-05-21 2:45 ` connect: don't request v2 when pushing (Re: Protocol v2 in v2.27) Jonathan Nieder
2020-05-21 3:26 ` Carlo Marcelo Arenas Belón
2020-05-21 11:54 ` Protocol v2 in v2.27 (Re: Re* [ANNOUNCE] Git v2.27.0-rc1) Derrick Stolee
2020-05-21 16:42 ` Junio C Hamano
2020-05-21 16:34 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200521002906.GA1273723@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).