git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Linux Kernel <linux-kernel@vger.kernel.org>,
	git-packagers@googlegroups.com
Subject: Re* [ANNOUNCE] Git v2.27.0-rc1
Date: Wed, 20 May 2020 13:31:30 -0700	[thread overview]
Message-ID: <xmqq5zcquz4t.fsf_-_@gitster.c.googlers.com> (raw)
In-Reply-To: <20200520193156.GA4700@coredump.intra.peff.net> (Jeff King's message of "Wed, 20 May 2020 15:31:56 -0400")

Jeff King <peff@peff.net> writes:

> On Wed, May 20, 2020 at 12:17:11PM -0700, Junio C Hamano wrote:
>
>> Git 2.27 Release Notes (draft)
>> ==============================
>> 
>> Updates since v2.26
>> -------------------
>> 
>> Backward compatibility notes
>
> Is it worth mentioning here the reversion of v2 as the default protocol?
>
> It does end up (along with the actual code fix) in the "fixes from
> v2.26" section:
>
>>  * Those fetching over protocol v2 from linux-next and other kernel
>>    repositories are reporting that v2 often fetches way too much than
>>    needed.
>>    (merge 11c7f2a30b jn/demote-proto2-from-default later to maint).
>> 
>>  * The upload-pack protocol v2 gave up too early before finding a
>>    common ancestor, resulting in a wasteful fetch from a fork of a
>>    project.  This has been corrected to match the behaviour of v0
>>    protocol.
>>    (merge 2f0a093dd6 jt/v2-fetch-nego-fix later to maint).
>
> but that's somewhat buried. I dunno. It is not likely to introduce _new_
> compatibility issues, but perhaps folks looking into compatibility stuff
> may want to know about the revert.

The promotion in Git 2.26 was buried in the "performance &
implementation details" section and not in the backward
compatibility section, so it feels a bit funny to highlight the
reversion.  In any case, here is what I prepared (but not committed
yet)

-- >8 --
Subject: [PATCH] RelNotes: advertise the demotion of protocol v2

In the upcoming release, the transport protocol v2 is no longer the
default; note it in the backward compatibility section.

Suggested-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 Documentation/RelNotes/2.27.0.txt | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/RelNotes/2.27.0.txt b/Documentation/RelNotes/2.27.0.txt
index 5fb8c0cf67..95a8d338ad 100644
--- a/Documentation/RelNotes/2.27.0.txt
+++ b/Documentation/RelNotes/2.27.0.txt
@@ -24,6 +24,10 @@ Backward compatibility notes
    users may find annoying---those who prefer not to rebase need to
    set the variable to false to squelch the warning.
 
+ * The transport protocol version 2, which was promoted to the default
+   in Git 2.26 release, turned out to have some remaining rough edges,
+   so it has been demoted from the default.
+
 
 UI, Workflows & Features
 

  parent reply	other threads:[~2020-05-20 20:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-20 19:17 [ANNOUNCE] Git v2.27.0-rc1 Junio C Hamano
2020-05-20 19:31 ` Jeff King
2020-05-20 20:02   ` Junio C Hamano
2020-05-20 20:31   ` Junio C Hamano [this message]
2020-05-20 21:24     ` Re* " Jeff King
2020-05-20 22:00     ` Protocol v2 in v2.27 (Re: Re* [ANNOUNCE] Git v2.27.0-rc1) Jonathan Nieder
2020-05-20 23:59       ` Junio C Hamano
2020-05-21  0:29         ` Jeff King
2020-05-21  2:15         ` Jonathan Nieder
2020-05-21  2:35           ` Carlo Marcelo Arenas Belón
2020-05-21  2:45             ` connect: don't request v2 when pushing (Re: Protocol v2 in v2.27) Jonathan Nieder
2020-05-21  3:26               ` Carlo Marcelo Arenas Belón
2020-05-21 11:54           ` Protocol v2 in v2.27 (Re: Re* [ANNOUNCE] Git v2.27.0-rc1) Derrick Stolee
2020-05-21 16:42             ` Junio C Hamano
2020-05-21 16:34           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5zcquz4t.fsf_-_@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git-packagers@googlegroups.com \
    --cc=git@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).