From: Jeff King <peff@peff.net>
To: Danh Doan <congdanhqx@gmail.com>
Cc: git@vger.kernel.org, Garima Singh <garima.singh@microsoft.com>,
Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH 0/2] minor fixups for gs/commit-graph-path-filter
Date: Fri, 24 Apr 2020 01:25:08 -0400 [thread overview]
Message-ID: <20200424052508.GC1648190@coredump.intra.peff.net> (raw)
In-Reply-To: <20200424010047.GD1949@danh.dev>
On Fri, Apr 24, 2020 at 08:00:47AM +0700, Danh Doan wrote:
> On 2020-04-23 16:58:51-0400, Jeff King <peff@peff.net> wrote:
> > These are just a few bits I noticed in the test-tool helper when the
> > topic hit next (my -Wunused-parameter patch complained that we never
> > looked at argc).
>
> I think I'll add this one to those few bits.
Yeah, they all look sensible (I should have looked for more "No newline"
cases.
> I've take another look into bloom.h.
>
> I think we should drop BITS_PER_WORD definition and use CHAR_BIT
> instead. It's a standard definition.
>
> To me, a WORD is an `int`, at least I was told that when I was still
> in university and study about computer science.
Yes, I agree it would be more clear as just CHAR_BIT if we are using
single-char words. But I suspect the code could be looking at the bit
patterns using larger word sizes (e.g., all of the ewah code uses 64-bit
words). That might be worth exploring.
-Peff
prev parent reply other threads:[~2020-04-24 5:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 20:58 [PATCH 0/2] minor fixups for gs/commit-graph-path-filter Jeff King
2020-04-23 20:59 ` [PATCH 1/2] test-bloom: fix some whitespace issues Jeff King
2020-04-23 21:01 ` Taylor Blau
2020-04-23 21:04 ` Jeff King
2020-04-23 20:59 ` [PATCH 2/2] test-bloom: check that we have expected arguments Jeff King
2020-04-23 21:02 ` Taylor Blau
2020-04-23 22:14 ` [PATCH 0/2] minor fixups for gs/commit-graph-path-filter Garima Singh
2020-04-24 16:58 ` Taylor Blau
2020-04-24 20:00 ` Junio C Hamano
2020-04-24 1:00 ` Danh Doan
2020-04-24 5:25 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424052508.GC1648190@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=congdanhqx@gmail.com \
--cc=dstolee@microsoft.com \
--cc=garima.singh@microsoft.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).