From: Taylor Blau <me@ttaylorr.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Garima Singh <garima.singh@microsoft.com>,
Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH 1/2] test-bloom: fix some whitespace issues
Date: Thu, 23 Apr 2020 15:01:55 -0600 [thread overview]
Message-ID: <20200423210155.GA46862@syl.local> (raw)
In-Reply-To: <20200423205907.GA1634224@coredump.intra.peff.net>
On Thu, Apr 23, 2020 at 04:59:07PM -0400, Jeff King wrote:
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> t/helper/test-bloom.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/t/helper/test-bloom.c b/t/helper/test-bloom.c
> index ce412664ba..f9c0ce2bae 100644
> --- a/t/helper/test-bloom.c
> +++ b/t/helper/test-bloom.c
> @@ -27,7 +27,7 @@ static void print_bloom_filter(struct bloom_filter *filter) {
> }
> printf("Filter_Length:%d\n", (int)filter->len);
> printf("Filter_Data:");
> - for (i = 0; i < filter->len; i++){
> + for (i = 0; i < filter->len; i++) {
Thanks for fixing the spacing, but I wonder if these braces should be
here at all. Since the body is one line long, maybe this should just be:
for (i = 0; i < filter->len; i++)
printf("%02x|", filter->data[i]);
> printf("%02x|", filter->data[i]);
> }
> printf("\n");
> @@ -50,13 +50,13 @@ int cmd__bloom(int argc, const char **argv)
> printf("Murmur3 Hash with seed=0:0x%08x\n", hashed);
> }
>
> - if (!strcmp(argv[1], "generate_filter")) {
> + if (!strcmp(argv[1], "generate_filter")) {
This spot looks good, and ditto for fixing the indentation.
> struct bloom_filter filter;
> int i = 2;
> filter.len = (settings.bits_per_entry + BITS_PER_WORD - 1) / BITS_PER_WORD;
> filter.data = xcalloc(filter.len, sizeof(unsigned char));
>
> - if (!argv[2]){
> + if (!argv[2]) {
Same note here about the brace.
> die("at least one input string expected");
> }
>
> @@ -68,7 +68,7 @@ int cmd__bloom(int argc, const char **argv)
> print_bloom_filter(&filter);
> }
>
> - if (!strcmp(argv[1], "get_filter_for_commit")) {
> + if (!strcmp(argv[1], "get_filter_for_commit")) {
> struct object_id oid;
> const char *end;
> if (parse_oid_hex(argv[2], &oid, &end))
> @@ -78,4 +78,4 @@ int cmd__bloom(int argc, const char **argv)
> }
>
> return 0;
> -}
> \ No newline at end of file
> +}
> --
> 2.26.2.827.g3c1233342b
>
Thanks,
Taylor
next prev parent reply other threads:[~2020-04-23 21:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 20:58 [PATCH 0/2] minor fixups for gs/commit-graph-path-filter Jeff King
2020-04-23 20:59 ` [PATCH 1/2] test-bloom: fix some whitespace issues Jeff King
2020-04-23 21:01 ` Taylor Blau [this message]
2020-04-23 21:04 ` Jeff King
2020-04-23 20:59 ` [PATCH 2/2] test-bloom: check that we have expected arguments Jeff King
2020-04-23 21:02 ` Taylor Blau
2020-04-23 22:14 ` [PATCH 0/2] minor fixups for gs/commit-graph-path-filter Garima Singh
2020-04-24 16:58 ` Taylor Blau
2020-04-24 20:00 ` Junio C Hamano
2020-04-24 1:00 ` Danh Doan
2020-04-24 5:25 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423210155.GA46862@syl.local \
--to=me@ttaylorr.com \
--cc=dstolee@microsoft.com \
--cc=garima.singh@microsoft.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).