From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH] Makefile: avoid running curl-config unnecessarily
Date: Wed, 15 Apr 2020 17:57:31 -0400 [thread overview]
Message-ID: <20200415215731.GA3595073@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqzhbc4e0s.fsf@gitster.c.googlers.com>
On Wed, Apr 15, 2020 at 02:47:47PM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > Junio, you may want to hold off on moving jk/build-with-right-curl to
> > next until we resolve this one way or the other.
> >
> > -- >8 --
> > Subject: [PATCH] Makefile: avoid running curl-config unnecessarily
>
> I think this has been accepted favourably after all? I am inclined
> to mark these three as ready for 'next'.
Yeah, my "until we resolve" was basically "do people find this Makefile
eval trick too gross". And I think the answer is that it's fine.
-Peff
prev parent reply other threads:[~2020-04-15 21:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 8:05 [PATCH 0/2] use `curl-config --cflags` Jeff King
2020-03-26 8:06 ` [PATCH 1/2] Makefile: avoid running curl-config multiple times Jeff King
2020-03-26 8:08 ` [PATCH 2/2] Makefile: use curl-config --cflags Jeff King
2020-03-27 22:12 ` [PATCH 0/2] use `curl-config --cflags` Junio C Hamano
2020-04-04 13:38 ` Johannes Schindelin
2020-04-04 14:58 ` [PATCH] Makefile: avoid running curl-config unnecessarily Jeff King
2020-04-05 1:33 ` Eric Sunshine
2020-04-05 18:44 ` Jeff King
2020-04-05 19:18 ` Eric Sunshine
2020-04-05 22:12 ` Johannes Schindelin
2020-04-05 22:12 ` Johannes Schindelin
2020-04-15 21:47 ` Junio C Hamano
2020-04-15 21:57 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415215731.GA3595073@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).