From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/2] use `curl-config --cflags`
Date: Sat, 4 Apr 2020 15:38:00 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2004041535360.46@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <20200326080540.GA2200522@coredump.intra.peff.net>
Hi Peff,
On Thu, 26 Mar 2020, Jeff King wrote:
> I was recently testing Git's behavior with respect to various versions
> of libcurl. So I built a one-off libcurl and installed it in /tmp/foo,
> but was surprised that:
>
> make CURL_CONFIG=/tmp/foo/bin/curl-config
>
> didn't work, since we do run "$(CURL_CONFIG) --libs". This fixes it,
> along with a minor optimization to the existing "--libs" call.
>
> [1/2]: Makefile: avoid running curl-config multiple times
> [2/2]: Makefile: use curl-config --cflags
I _suspect_ that this is responsible for the build failure
make: curl-config: Command not found
at https://github.com/git/git/runs/556459415#step:4:674
Do we need this to fix this?
-- snip --
diff --git a/ci/test-documentation.sh b/ci/test-documentation.sh
index de41888430a..325b4cc6185 100755
--- a/ci/test-documentation.sh
+++ b/ci/test-documentation.sh
@@ -11,6 +11,7 @@ filter_log () {
-e '/^ \* new asciidoc flags$/d' \
-e '/stripped namespace before processing/d' \
-e '/Attributed.*IDs for element/d' \
+ -e '/curl-config: Command not found/d' \
"$1"
}
-- snap --
Ciao,
Dscho
>
> Makefile | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
> -Peff
>
next prev parent reply other threads:[~2020-04-04 13:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 8:05 [PATCH 0/2] use `curl-config --cflags` Jeff King
2020-03-26 8:06 ` [PATCH 1/2] Makefile: avoid running curl-config multiple times Jeff King
2020-03-26 8:08 ` [PATCH 2/2] Makefile: use curl-config --cflags Jeff King
2020-03-27 22:12 ` [PATCH 0/2] use `curl-config --cflags` Junio C Hamano
2020-04-04 13:38 ` Johannes Schindelin [this message]
2020-04-04 14:58 ` [PATCH] Makefile: avoid running curl-config unnecessarily Jeff King
2020-04-05 1:33 ` Eric Sunshine
2020-04-05 18:44 ` Jeff King
2020-04-05 19:18 ` Eric Sunshine
2020-04-05 22:12 ` Johannes Schindelin
2020-04-05 22:12 ` Johannes Schindelin
2020-04-15 21:47 ` Junio C Hamano
2020-04-15 21:57 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2004041535360.46@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).