From: Jeff King <peff@peff.net>
To: Taylor Blau <me@ttaylorr.com>
Cc: Derrick Stolee <stolee@gmail.com>,
Konstantin Tokarev <annulen@yandex.ru>,
Jonathan Tan <jonathantanmy@google.com>,
git@vger.kernel.org
Subject: Re: Inefficiency of partial shallow clone vs shallow clone + "old-style" sparse checkout
Date: Wed, 1 Apr 2020 08:18:46 -0400 [thread overview]
Message-ID: <20200401121846.GB1916590@coredump.intra.peff.net> (raw)
In-Reply-To: <20200331214653.GA95875@syl.local>
On Tue, Mar 31, 2020 at 03:46:53PM -0600, Taylor Blau wrote:
> On Sat, Mar 28, 2020 at 12:58:41PM -0400, Derrick Stolee wrote:
>
> > This is a good find, and I expect we will find more "opportunities"
> > to insert OBJECT_INFO_SKIP_FETCH_OBJECT like this.
The worst part is that we _did_ find this in git-fetch, and fixed it in
3e96c66805 (partial-clone: avoid fetching when looking for objects,
2020-02-21). But as usual git-clone has its own kind-of-the-same
implementation of the same feature.
> Should we turn this into a proper patch and have it reviewed? It seems
> to be helping the situation, and after thinking about it (only briefly,
> but more than not ;-)), this seems like the right direction.
Yes, I wanted to simplify the test and double-check the addition of
QUICK. See the patch I just posted in:
https://lore.kernel.org/git/20200401121537.GA1916590@coredump.intra.peff.net/
-Peff
next prev parent reply other threads:[~2020-04-01 12:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 21:08 Inefficiency of partial shallow clone vs shallow clone + "old-style" sparse checkout Konstantin Tokarev
2020-03-28 14:40 ` Jeff King
2020-03-28 16:58 ` Derrick Stolee
2020-03-31 21:46 ` Taylor Blau
2020-04-01 12:18 ` Jeff King [this message]
2020-03-31 22:10 ` Konstantin Tokarev
2020-03-31 22:23 ` Konstantin Tokarev
2020-04-01 0:09 ` Derrick Stolee
2020-04-01 1:49 ` Konstantin Tokarev
2020-04-01 11:44 ` Jeff King
2020-04-01 12:15 ` [PATCH] clone: use "quick" lookup while following tags Jeff King
2020-04-01 19:12 ` Konstantin Tokarev
2020-04-01 19:25 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200401121846.GB1916590@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=annulen@yandex.ru \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=me@ttaylorr.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).