From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id D55FA1F487 for ; Wed, 1 Apr 2020 12:18:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732354AbgDAMSr (ORCPT ); Wed, 1 Apr 2020 08:18:47 -0400 Received: from cloud.peff.net ([104.130.231.41]:58198 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1732169AbgDAMSr (ORCPT ); Wed, 1 Apr 2020 08:18:47 -0400 Received: (qmail 1722 invoked by uid 109); 1 Apr 2020 12:18:47 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Wed, 01 Apr 2020 12:18:47 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 7725 invoked by uid 111); 1 Apr 2020 12:28:54 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Wed, 01 Apr 2020 08:28:54 -0400 Authentication-Results: peff.net; auth=none Date: Wed, 1 Apr 2020 08:18:46 -0400 From: Jeff King To: Taylor Blau Cc: Derrick Stolee , Konstantin Tokarev , Jonathan Tan , git@vger.kernel.org Subject: Re: Inefficiency of partial shallow clone vs shallow clone + "old-style" sparse checkout Message-ID: <20200401121846.GB1916590@coredump.intra.peff.net> References: <2814631585342072@sas8-da6d7485e0c7.qloud-c.yandex.net> <20200328144023.GB1198080@coredump.intra.peff.net> <20200331214653.GA95875@syl.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200331214653.GA95875@syl.local> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Mar 31, 2020 at 03:46:53PM -0600, Taylor Blau wrote: > On Sat, Mar 28, 2020 at 12:58:41PM -0400, Derrick Stolee wrote: > > > This is a good find, and I expect we will find more "opportunities" > > to insert OBJECT_INFO_SKIP_FETCH_OBJECT like this. The worst part is that we _did_ find this in git-fetch, and fixed it in 3e96c66805 (partial-clone: avoid fetching when looking for objects, 2020-02-21). But as usual git-clone has its own kind-of-the-same implementation of the same feature. > Should we turn this into a proper patch and have it reviewed? It seems > to be helping the situation, and after thinking about it (only briefly, > but more than not ;-)), this seems like the right direction. Yes, I wanted to simplify the test and double-check the addition of QUICK. See the patch I just posted in: https://lore.kernel.org/git/20200401121537.GA1916590@coredump.intra.peff.net/ -Peff