From: Damien Robert <damien.olivier.robert@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH 2/2] pack-objects: change the name of add_objects_in_unpacked_packs
Date: Fri, 28 Feb 2020 17:01:37 +0100 [thread overview]
Message-ID: <20200228160137.iqd3pxtsdameijs3@feanor> (raw)
In-Reply-To: <20200228154357.1710521-3-damien.olivier.robert+git@gmail.com>
From Damien Robert, Fri 28 Feb 2020 at 16:43:57 (+0100) :
> Now the function simply iterate through all packs (more precisely all
> local packs not marked as .keep), and add all objects not already in the
> object list.
By the way is there a corner case here?
When using `git repack --keep-unreachable --pack-kept-objects`, since
`add_objects_in_unpacked_packs` does not add objects in *.keep packs, then
unreachable objects there won't be added. Or am I missing something?
prev parent reply other threads:[~2020-02-28 16:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 15:43 [PATCH 0/2] Documentation of pack and repack Damien Robert
2020-02-28 15:43 ` [PATCH 1/2] doc: update the documentation of pack-objects " Damien Robert
2020-03-02 18:57 ` Junio C Hamano
2020-03-03 17:41 ` Damien Robert
2020-03-03 18:49 ` Junio C Hamano
2020-03-03 21:23 ` Damien Robert
2020-03-03 22:29 ` Junio C Hamano
2020-03-12 17:09 ` [PATCH v2 0/3] Documentation of pack " Damien Robert
2020-03-12 17:09 ` [PATCH v2 1/3] pack-objects: change the name of add_objects_in_unpacked_packs Damien Robert
2020-03-12 17:09 ` [PATCH v2 2/3] doc: update the documentation of pack-objects and repack Damien Robert
2020-03-12 17:09 ` [PATCH v2 3/3] doc: add a short explanation for git-repack options Damien Robert
2020-03-25 22:15 ` [PATCH v2 0/3] Documentation of pack and repack Damien Robert
2020-03-27 22:21 ` Junio C Hamano
2020-02-28 15:43 ` [PATCH 2/2] pack-objects: change the name of add_objects_in_unpacked_packs Damien Robert
2020-02-28 16:01 ` Damien Robert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200228160137.iqd3pxtsdameijs3@feanor \
--to=damien.olivier.robert@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).