From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 1CDD61F619 for ; Fri, 28 Feb 2020 16:01:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727431AbgB1QBm (ORCPT ); Fri, 28 Feb 2020 11:01:42 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:54348 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727104AbgB1QBl (ORCPT ); Fri, 28 Feb 2020 11:01:41 -0500 Received: by mail-wm1-f66.google.com with SMTP id z12so3704281wmi.4 for ; Fri, 28 Feb 2020 08:01:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=naHpl/mMf9u1oniL8RJtksV/+k8kb/1WPoeqYHsDJ2s=; b=m+NMQd/5GWlg5rqAzNb9V03yCk4TCedWZhsgeK9GVy+/B6jTgWb8HGt0K2kkNClNTg uU9x/Oy6BQWbgLzpAZYhiCADUJ3X0aNLelNqhHl7opB+Ld0hVIXgm6Fjdm47ryBiK1vt t7uFJ7Dz+fvYyoWY7/LY/K8PVU4xobD7sG1bIdf1JJN15zgKijCnOfE4CoxiaA/5psJN g33XN4zfQ+NTP/pVxQ9Wo82i2IWFBHqHMfjTeL+fH1SRL/bvQGlpl3xtBpXyLAh5s5/B YGbn3GeGFEehE37kfIlJ/rcOO8TQ3UOM8YjR3+Zej6cjheM2+NvmdinSuDhEZSSx0UZY 3igQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=naHpl/mMf9u1oniL8RJtksV/+k8kb/1WPoeqYHsDJ2s=; b=Rti4s7iVdVBDss1/vHWiqToQj6Te9WBvopCYOpOcpQn3m5H3eR/DHgqZRa2uJfDZkY 1Rv+7lA3F47Man/VUFmWyk3RSWxbkqbAKkmm/VXnXrYUXAE2qWVY0OQSVFaiUnJ537MP /5uvuXCRLh3ZgNE/6AULT9xNgF128A4pa7BH2bxlpLzKSJhs5AGKnGIfEKnbFABxznoe u7oHThkab7NRr397VsoWJs1SrJB3f7lq12OQ20N9NaUIl2p3ix6CmPAlapdurwo7xdd1 zAkTiMBtDXgxBBYR2KNmQAfvK1wR2tjFjivACS4CuMqCvTpLf9BQiYVyQRiYEM/Srv3T EgWg== X-Gm-Message-State: APjAAAVBmTKs88arohp0PrRPLkKt+lBj0NimcDaUcOmdIcT9oIEPXU2+ Wfeo+NIOEhjKL4AUmTKSX7ig4x28CHY= X-Google-Smtp-Source: APXvYqzO96GXAU6bN9g21+6Kxu4JgQOEKEyQVLFZw4D12OvaAEnPMV83OvE/0LepHr2+ulZFLn+E8w== X-Received: by 2002:a7b:c14e:: with SMTP id z14mr5345683wmi.58.1582905699462; Fri, 28 Feb 2020 08:01:39 -0800 (PST) Received: from feanor (87-231-246-247.rev.numericable.fr. [87.231.246.247]) by smtp.gmail.com with ESMTPSA id h81sm2187649wme.12.2020.02.28.08.01.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 08:01:38 -0800 (PST) From: Damien Robert X-Google-Original-From: Damien Robert Date: Fri, 28 Feb 2020 17:01:37 +0100 To: git@vger.kernel.org Subject: Re: [PATCH 2/2] pack-objects: change the name of add_objects_in_unpacked_packs Message-ID: <20200228160137.iqd3pxtsdameijs3@feanor> X-PGP-Key: http://www.normalesup.org/~robert/pro/files/Damien_Olivier_Robert.asc X-Start-Date: Fri, 28 Feb 2020 16:57:57 +0100 References: <20200228154357.1710521-1-damien.olivier.robert+git@gmail.com> <20200228154357.1710521-3-damien.olivier.robert+git@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200228154357.1710521-3-damien.olivier.robert+git@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org >From Damien Robert, Fri 28 Feb 2020 at 16:43:57 (+0100) : > Now the function simply iterate through all packs (more precisely all > local packs not marked as .keep), and add all objects not already in the > object list. By the way is there a corner case here? When using `git repack --keep-unreachable --pack-kept-objects`, since `add_objects_in_unpacked_packs` does not add objects in *.keep packs, then unreachable objects there won't be added. Or am I missing something?