list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <>
To: edef <>
Subject: Re: [PATCH] mailinfo: don't discard names under 3 characters
Date: Thu, 30 Jan 2020 05:06:54 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, Dec 20, 2019 at 12:39:48AM +0000, edef wrote:

> I sometimes receive patches from people with short mononyms, and in my
> cultural environment these are not uncommon. To my dismay, git-am
> currently discards their names, and replaces them with their email
> addresses.
> Link:
> ---
> I'm not *completely* sure there's even a case where `src = email` is 
> the right thing to do, but I'd rather not modify this code more than 
> strictly necessary.

I think this makes sense. There's a lot of heuristic voodoo in this old
mailinfo code, but I think getting people's legitimate short names wrong
is worse than the likelihood that this is actually helping some
broken-parsing case in any meaningful way. I suspect this code predates
us parsing the headers carefully according to the standard (it looks to
be from 2744b2344d on 2005-04-11, which is quite early!).

The 60-char maximum also seems like something people might run afoul of
in certain cultures. Is it worth bumping, too?

I think your patch slipped through the cracks, coming as it did over the
holidays. It's probably worth re-posting it (with your signed-off-by).


  parent reply	other threads:[~2020-01-30 10:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-20  0:39 [PATCH] mailinfo: don't discard names under 3 characters edef
2019-12-20 13:37 ` edef
2020-01-30 10:06 ` Jeff King [this message]
2021-05-16 15:07   ` [PATCH v2] " edef
2021-05-16 22:57     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).