From: Junio C Hamano <gitster@pobox.com>
To: edef <edef@edef.eu>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] mailinfo: don't discard names under 3 characters
Date: Mon, 17 May 2021 07:57:43 +0900 [thread overview]
Message-ID: <xmqq4kf25lso.fsf@gitster.g> (raw)
In-Reply-To: <20210516150719.49710-1-edef@edef.eu> (edef@edef.eu's message of "Sun, 16 May 2021 15:07:19 +0000")
edef <edef@edef.eu> writes:
> I sometimes receive patches from people with short mononyms, and in my
> cultural environment these are not uncommon. To my dismay, git-am
> currently discards their names, and replaces them with their email
> addresses.
>
> Link: https://www.kalzumeus.com/2010/06/17/falsehoods-programmers-believe-about-names/
> Signed-off-by: edef <edef@edef.eu>
> ---
> Rebased and with Signed-off-by this time :)
>
> mailinfo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mailinfo.c b/mailinfo.c
> index 95ce191f38..626228654c 100644
> --- a/mailinfo.c
> +++ b/mailinfo.c
> @@ -19,7 +19,7 @@ static void cleanup_space(struct strbuf *sb)
> static void get_sane_name(struct strbuf *out, struct strbuf *name, struct strbuf *email)
> {
> struct strbuf *src = name;
> - if (name->len < 3 || 60 < name->len || strpbrk(name->buf, "@<>"))
> + if (!name->len || 60 < name->len || strpbrk(name->buf, "@<>"))
> src = email;
> else if (name == out)
> return;
Wow. The original of this was from very late in 2019, wasn't it?
Thanks for updating; will queue.
prev parent reply other threads:[~2021-05-16 22:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 0:39 [PATCH] mailinfo: don't discard names under 3 characters edef
2019-12-20 13:37 ` edef
2020-01-30 10:06 ` Jeff King
2021-05-16 15:07 ` [PATCH v2] " edef
2021-05-16 22:57 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4kf25lso.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=edef@edef.eu \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).