Re: [PATCH] git-gui: allow closing console window with Escape

[Pratyush Yadav <me@yadavpratyush.com>]

(+Cc Dscho who got dropped from the Cc list somewhere along the way)

Hi Vasili,

On 10/12/19 01:11PM, Vasili Novikov wrote:
> Hi all,
> Sorry if threading was broken: Thunderbird possibly doesn't fully support
> mbox import that I used. Or I did it unproperly. Either way, hope it's
> correct now.

Threading seems to works fine for you. I meant avoiding top posting. 
More explanation on top posting and bottom posting here 
http://www.idallen.com/topposting.html
 
> Thanks for explaining. I misunderstood the purpose of the window. If it's a
> slow ongoing task, then indeed it should not be closeable with Esc. I'd say
> it makes sense to allow Esc to work when it gets into "Success" state
> though, as in the screenshot.

Hmm, I like the idea. Does that work for you Dscho?
 
> 
> Thanks,
> Vasili
> 
> On 10/12/2019 13.02, Pratyush Yadav wrote:
> > Hi Vasili,
> > 
> > Please try to not top-post on the list.
> > 
> > On 09/12/19 04:53PM, Vasili Novikov wrote:
> > > What have console windows to do with git gui though? I'd work under the
> > 
> > Well, the window/popup in question is internally named "console" and is
> > defined in lib/console.tcl. It is used by many parts of git-gui that
> > need to execute a command and show the output to the user.
> > 
> > > following assumptions:
> > > * we're talking about a GUI window, not a TUI one
> > > * the window has no useful information at all except the fact that something
> > > has "finished", is "done". There are no actions that you can take except to
> > > dismiss the window.
> > It also shows you the output of a command currently in progress (like
> > git-push). My main argument with avoiding Escape is that people often
> > expect Escape to stop an ongoing command. In this case though, closing
> > the window does not actually stop the command. It keeps going on in the
> > background.
> > 
> > But since the window is gone, people might think the command they were
> > running has stopped, which might lead to some unexpected results.
> > 
> > > If we agree on the following assumptions, then I see these real-world
> > > examples:
> > > * Mousepad > About > Esc = closes the popup
> > > * Firefox > About > Esc = closes the popup
> > > * Thunar > select any file and ask its properties > Esc = closes the window
> > > * file-roller (GNOME compressed archive manager) > Extract archive > Observe
> > > success window upon completion > Esc = closes the window.
> > 
> > In this case, the thing is done. There is no ongoing task. Not quite the
> > case with the console window in git-gui, which can also show ongoing
> > tasks.
> > > Are there any real-world examples where `Ctrl W` or `Esc D` work but `Esc`
> > > doesn't, to consider these alternatives as more intuitive to users?

-- 
Regards,
Pratyush Yadav