From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Pratyush Yadav <me@yadavpratyush.com>
Cc: Vasili Novikov <vasilii.novikov@zivver.com>, git@vger.kernel.org
Subject: Re: [PATCH] git-gui: allow closing console window with Escape
Date: Fri, 13 Dec 2019 14:29:35 +0100 (CET) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1912131428490.46@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <20191210133105.apfim55w7osvskvh@yadavpratyush.com>
Hi,
On Tue, 10 Dec 2019, Pratyush Yadav wrote:
> On 10/12/19 01:11PM, Vasili Novikov wrote:
>
> > Sorry if threading was broken: Thunderbird possibly doesn't fully support
> > mbox import that I used. Or I did it unproperly. Either way, hope it's
> > correct now.
>
> Threading seems to works fine for you. I meant avoiding top posting.
> More explanation on top posting and bottom posting here
> http://www.idallen.com/topposting.html
>
> > Thanks for explaining. I misunderstood the purpose of the window. If it's a
> > slow ongoing task, then indeed it should not be closeable with Esc. I'd say
> > it makes sense to allow Esc to work when it gets into "Success" state
> > though, as in the screenshot.
>
> Hmm, I like the idea. Does that work for you Dscho?
I'm fine with whatever you settle with, I am not really a Git GUI user (I
just deal with a couple of those users in my role as Git for Windows
maintainer).
Ciao,
Dscho
prev parent reply other threads:[~2019-12-13 13:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 22:20 [PATCH] git-gui: allow closing console window with Escape Pratyush Yadav
2019-12-07 16:24 ` Johannes Schindelin
2019-12-08 19:40 ` Pratyush Yadav
2019-12-09 9:18 ` Johannes Schindelin
2019-12-09 15:53 ` Vasili Novikov
2019-12-10 12:02 ` Pratyush Yadav
2019-12-10 12:11 ` Vasili Novikov
2019-12-10 13:31 ` Pratyush Yadav
2019-12-13 13:29 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1912131428490.46@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=me@yadavpratyush.com \
--cc=vasilii.novikov@zivver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).