From: Denton Liu <liu.denton@gmail.com>
To: Beat Bolli <dev+git@drbeat.li>
Cc: git@vger.kernel.org, Paul Mackerras <paulus@ozlabs.org>
Subject: Re: [PATCH 1/2] gitk: use --pretty=reference to generate the commit summary
Date: Mon, 9 Dec 2019 11:33:48 -0800 [thread overview]
Message-ID: <20191209193348.GA29379@generichostname> (raw)
In-Reply-To: <20191209182534.309884-1-dev+git@drbeat.li>
Hi Beat,
On Mon, Dec 09, 2019 at 07:25:33PM +0100, Beat Bolli wrote:
> Git learned the "reference" pretty format in 1f0fc1db85 (pretty:
> implement 'reference' format, 2019-11-19). Use it also in gitk instead
> of duplicating the format string. This way, gitk always follows the
> formatting convention defined by git.
>
> Signed-off-by: Beat Bolli <dev+git@drbeat.li>
Heh, I had the exact same patch queued up and ready to be sent[1].
However, I was waiting until the feature actually got merged into master
before pulling the trigger on sending it out because according to
howto/maintain-git.txt:
* Being in the 'next' branch is not a guarantee for a topic to
be included in the next feature release. Being in the
'master' branch typically is.
Feel free to steal parts (or all of) my commit message since I think it
goes into a bit more detail if you think it works better. Or if you
don't want to deal with the burden of fixing this patch, I'll send out
mine at a later time (whenever 'dl/pretty-reference' gets merged to
'master').
> ---
> Junio, this goes on top of dl/pretty-reference, currently in pu.
Since this is a patch for gitk, it should be sent to Paul Mackerras, who
is the maintanier of gitk.
>
> Thanks!
>
> gitk-git/gitk | 3 +--
Also, It should be based on his subtree, i.e. the file change should say
gitk, not gitk-git/gitk. You can find the tip of his tree by fetching
git://ozlabs.org/~paulus/gitk.
Thanks,
Denton
[1]: https://github.com/Denton-L/git/commit/da9321b1bd56aafd16c8dcb99d5d628b79e2244e
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/gitk-git/gitk b/gitk-git/gitk
> index a14d7a16b2..cc89fb25d2 100755
> --- a/gitk-git/gitk
> +++ b/gitk-git/gitk
> @@ -9392,8 +9392,7 @@ proc mktaggo {} {
> proc copysummary {} {
> global rowmenuid autosellen
>
> - set format "%h (\"%s\", %ad)"
> - set cmd [list git show -s --pretty=format:$format --date=short]
> + set cmd [list git show -s --pretty=reference]
> if {$autosellen < 40} {
> lappend cmd --abbrev=$autosellen
> }
> --
> 2.23.0.13.gecf2037ff6
>
next prev parent reply other threads:[~2019-12-09 19:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 18:25 [PATCH 1/2] gitk: use --pretty=reference to generate the commit summary Beat Bolli
2019-12-09 18:25 ` [PATCH 2/2] gitk: rename "commit summary" to "commit reference" Beat Bolli
2019-12-09 19:33 ` Denton Liu [this message]
2019-12-10 1:46 ` [PATCH 1/2] gitk: use --pretty=reference to generate the commit summary Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191209193348.GA29379@generichostname \
--to=liu.denton@gmail.com \
--cc=dev+git@drbeat.li \
--cc=git@vger.kernel.org \
--cc=paulus@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).