From: Beat Bolli <dev+git@drbeat.li>
To: git@vger.kernel.org
Cc: Paul Mackerras <paulus@ozlabs.org>, Beat Bolli <dev+git@drbeat.li>
Subject: [PATCH 2/2] gitk: rename "commit summary" to "commit reference"
Date: Mon, 9 Dec 2019 19:25:34 +0100 [thread overview]
Message-ID: <20191209182534.309884-2-dev+git@drbeat.li> (raw)
In-Reply-To: <20191209182534.309884-1-dev+git@drbeat.li>
Now that the commit reference format has a canonical name, let's use this
name in gitk's UI and implementation.
Signed-off-by: Beat Bolli <dev+git@drbeat.li>
---
This commit is optional IMO, but I think it makes sense to use the same
words for the same things.
gitk-git/gitk | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index cc89fb25d2..72c7feec9a 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -2640,7 +2640,7 @@ proc makewindow {} {
{mc "Diff selected -> this" command {diffvssel 1}}
{mc "Make patch" command mkpatch}
{mc "Create tag" command mktag}
- {mc "Copy commit summary" command copysummary}
+ {mc "Copy commit reference" command copyreference}
{mc "Write commit to file" command writecommit}
{mc "Create new branch" command mkbranch}
{mc "Cherry-pick this commit" command cherrypick}
@@ -9389,17 +9389,17 @@ proc mktaggo {} {
mktagcan
}
-proc copysummary {} {
+proc copyreference {} {
global rowmenuid autosellen
set cmd [list git show -s --pretty=reference]
if {$autosellen < 40} {
lappend cmd --abbrev=$autosellen
}
- set summary [eval exec $cmd $rowmenuid]
+ set reference [eval exec $cmd $rowmenuid]
clipboard clear
- clipboard append $summary
+ clipboard append $reference
}
proc writecommit {} {
--
2.23.0.13.gecf2037ff6
next prev parent reply other threads:[~2019-12-09 18:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 18:25 [PATCH 1/2] gitk: use --pretty=reference to generate the commit summary Beat Bolli
2019-12-09 18:25 ` Beat Bolli [this message]
2019-12-09 19:33 ` Denton Liu
2019-12-10 1:46 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191209182534.309884-2-dev+git@drbeat.li \
--to=dev+git@drbeat.li \
--cc=git@vger.kernel.org \
--cc=paulus@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).