git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: 加藤一博 <kato-k@ksysllc.co.jp>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
	Paul Mackerras <paulus@ozlabs.org>
Subject: Re: [PATCH] gitk branch name encoding utf-8 probrem
Date: Wed, 4 Dec 2019 14:29:21 -0800
Message-ID: <20191204222921.GB195537@google.com> (raw)
In-Reply-To: <TY2PR01MB24271C32E2FD9FD8C27CA8C2CA5D0@TY2PR01MB2427.jpnprd01.prod.outlook.com>

(cc-ing Paul, gitk expert)
Hi!

加藤一博 wrote:

> Here is a patch to gitk branch name utf-8 probrem.

Thanks for reporting it.  Can you provide a short summary here of
the problem that we can use for a self-contained description in the
commit log?  See
https://www.kernel.org/pub/software/scm/git/docs/SubmittingPatches.html#describe-changes
for more on this subject.

May we also have your sign-off?  See
https://www.kernel.org/pub/software/scm/git/docs/SubmittingPatches.html#sign-off
for what this means.

Thanks and hope that helps,
Jonathan

> See issue
> https://github.com/kkato233/gitk/issues/1
> and fix it 
> https://github.com/kkato233/gitk/pull/2
> 
> 
> ---
> 
> diff --git a/gitk b/gitk
> index abe4805..3f61a5b 100755
> --- a/gitk
> +++ b/gitk
> @@ -1780,11 +1780,15 @@ proc readrefs {} {
>      global otherrefids idotherrefs mainhead mainheadid
>      global selecthead selectheadid
>      global hideremotes
> +    global tclencoding
> 
>      foreach v {tagids idtags headids idheads otherrefids idotherrefs} {
>         unset -nocomplain $v
>      }
>      set refd [open [list | git show-ref -d] r]
> +    if {$tclencoding != {}} {
> +       fconfigure $refd -encoding $tclencoding
> +    }
>      while {[gets $refd line] >= 0} {
>         if {[string index $line 40] ne " "} continue
>         set id [string range $line 0 39]

  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04 18:36 加藤一博
2019-12-04 22:29 ` Jonathan Nieder [this message]
2019-12-05 15:02   ` 加藤一博
2019-12-05 20:28     ` Junio C Hamano
2019-12-05 20:40       ` Pratyush Yadav
2019-12-05 20:50       ` Pratyush Yadav

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191204222921.GB195537@google.com \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=kato-k@ksysllc.co.jp \
    --cc=paulus@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

git@vger.kernel.org list mirror (unofficial, one of many)

Archives are clonable:
	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.org/gmane.comp.version-control.git

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git