From: Pratyush Yadav <me@yadavpratyush.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Paul Mackerras" <paulus@ozlabs.org>,
"git@vger.kernel.org" <git@vger.kernel.org>,
加藤一博 <kato-k@ksysllc.co.jp>
Subject: Re: [PATCH] gitk branch name encoding utf-8 probrem
Date: Fri, 6 Dec 2019 02:10:46 +0530 [thread overview]
Message-ID: <20191205204046.waceacp5b3t5djrc@yadavpratyush.com> (raw)
In-Reply-To: <xmqqimmuzfe1.fsf@gitster-ct.c.googlers.com>
On 05/12/19 12:28PM, Junio C Hamano wrote:
> 加藤一博 <kato-k@ksysllc.co.jp> writes:
>
> > fix branch name encoding error on gitk.
> >
> > git checkout -b '漢字'
> > gitk show branch name broken like this '貍「蟄'
> > fix this problem.
>
> Paul (the gitk maintainer), the patch text itself does look
> reasonable.
>
> After "git checkout -b '漢字'" to create a branch with UTF-8
> character in it, "gitk" shows the branch name incorrectly, as it
> forgets to turns the bytes read from the "git show-ref" command
Minor typo: s/turns/turn/
> into Unicode characters.
>
> is how I would phrase the log message.
>
> Thanks.
--
Regards,
Pratyush Yadav
next prev parent reply other threads:[~2019-12-05 20:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 18:36 [PATCH] gitk branch name encoding utf-8 probrem 加藤一博
2019-12-04 22:29 ` Jonathan Nieder
2019-12-05 15:02 ` 加藤一博
2019-12-05 20:28 ` Junio C Hamano
2019-12-05 20:40 ` Pratyush Yadav [this message]
2019-12-05 20:50 ` Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191205204046.waceacp5b3t5djrc@yadavpratyush.com \
--to=me@yadavpratyush.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kato-k@ksysllc.co.jp \
--cc=paulus@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).