From: Ingo Rohloff <ingo.rohloff@lauterbach.com>
To: git@vger.kernel.org
Cc: Ingo Rohloff <ingo.rohloff@lauterbach.com>
Subject: [PATCH v2 3/4] remote: Prevent users from creating remotes named "refs" or "refs/*"
Date: Thu, 7 Nov 2019 20:07:49 +0100 [thread overview]
Message-ID: <20191107190750.26674-4-ingo.rohloff@lauterbach.com> (raw)
In-Reply-To: <20191107190750.26674-1-ingo.rohloff@lauterbach.com>
To explain the intention, here is an example:
A user executes
git remote add refs/heads <URL>
git fetch refs/heads
after this operation
git log refs/heads/master
will very likely complain that this reference is ambiguous.
The reason is, that you now very likely have the following two
references which both match:
refs/heads/master
refs/remotes/refs/heads/master
git cannot decide which of the two references is meant.
By preventing the creation of remotes which are named
refs or refs/*
this issue is circumvented:
git log refs/*
will never refer to a remote tracking branch located under
refs/remotes/refs/*
because such remotes should not exist.
Signed-off-by: Ingo Rohloff <ingo.rohloff@lauterbach.com>
---
builtin/remote.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/builtin/remote.c b/builtin/remote.c
index 5591cef775..2272c16d18 100644
--- a/builtin/remote.c
+++ b/builtin/remote.c
@@ -189,6 +189,9 @@ static int add(int argc, const char **argv)
name = argv[0];
url = argv[1];
+ if (newname_has_bad_prefix(name))
+ die(_("Invalid new remote name: '%s'"), name);
+
remote = remote_get(name);
if (remote_is_configured(remote, 1))
die(_("remote %s already exists."), name);
--
2.24.0
next prev parent reply other threads:[~2019-11-07 19:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 16:56 [PATCH] branch: Forbid to create local branches with confusing names Ingo Rohloff
2019-11-06 22:15 ` Johannes Schindelin
2019-11-07 19:04 ` Ingo Rohloff
2019-11-07 6:05 ` Junio C Hamano
2019-11-07 12:54 ` Ingo Rohloff
2019-11-08 2:54 ` Junio C Hamano
2019-11-08 12:45 ` Ingo Rohloff
2019-11-07 19:07 ` [PATCH v2 0/4] Do not create new refnames "refs" or "refs/*" Ingo Rohloff
2019-11-07 19:07 ` [PATCH v2 1/4] refs: new function newname_has_bad_prefix Ingo Rohloff
2019-11-07 19:07 ` [PATCH v2 2/4] branch: Prevent creation of local branches named "refs" or "refs/*" Ingo Rohloff
2019-11-07 19:07 ` Ingo Rohloff [this message]
2019-11-07 19:07 ` [PATCH v2 4/4] tag: Prevent users from creating tags " Ingo Rohloff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107190750.26674-4-ingo.rohloff@lauterbach.com \
--to=ingo.rohloff@lauterbach.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).