From: Jeff King <firstname.lastname@example.org>
To: "SZEDER Gábor" <email@example.com>
Cc: Junio C Hamano <firstname.lastname@example.org>,
email@example.com, Taylor Blau <firstname.lastname@example.org>,
Charles Diza <email@example.com>,
Johannes Schindelin <firstname.lastname@example.org>
Subject: Re: [PATCH 0/2] Revert "progress: use term_clear_line()"
Date: Wed, 2 Oct 2019 11:47:35 -0400 [thread overview]
Message-ID: <20191002154734.GC6116@sigill.intra.peff.net> (raw)
On Mon, Sep 16, 2019 at 10:54:10PM +0200, SZEDER Gábor wrote:
> > Yes on that final bit. We could always fall back to (4) if the terminal
> > information is not available, but given that the benefit is mostly in
> > simplifying the code, I don't know if it's worth carrying around _two_
> > solutions.
> Ok, so here is a patch to revert 5b12e3123b (progress: use
> term_clear_line(), 2019-06-24) with proper explanation.
> As a bonus there is a new test script exercising the progress display
> as well, in particular how it covers up the previous progress line, so
> we may have a bit more confidence in it.
Thanks for doing this. It's especially nice to get test coverage for the
progress meters, which have traditionally been neglected.
I'm a little late on my review, as it looks like this has already hit
next, but it looks pretty good to me.
My only complaint is that I think putting the new "private" bits of the
progress API into the header (with a comment) is a lesser evil than
re-declaring them in test-progress.c (if only because the compiler could
tell us if the two get out of sync). But I can live with it either way.
next prev parent reply other threads:[~2019-10-02 15:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 14:20 v2.22.1 and later regression wrt display of progress indicators Charles Diza
2019-08-22 16:07 ` SZEDER Gábor
2019-08-22 16:29 ` Jeff King
2019-08-22 16:40 ` SZEDER Gábor
2019-08-22 17:04 ` Jeff King
2019-08-22 17:19 ` Taylor Blau
2019-09-16 20:54 ` [PATCH 0/2] Revert "progress: use term_clear_line()" SZEDER Gábor
2019-09-16 20:54 ` [PATCH 1/2] " SZEDER Gábor
2019-09-16 20:54 ` [PATCH 2/2] Test the progress display SZEDER Gábor
2019-10-02 15:47 ` Jeff King [this message]
2019-08-22 17:16 ` v2.22.1 and later regression wrt display of progress indicators Taylor Blau
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).