mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <>
To: "SZEDER Gábor" <>
Cc: Charles Diza <>,
	Junio C Hamano <>,
	Johannes Schindelin <>,
Subject: Re: v2.22.1 and later regression wrt display of progress indicators
Date: Thu, 22 Aug 2019 13:04:35 -0400	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, Aug 22, 2019 at 06:40:32PM +0200, SZEDER Gábor wrote:

> > Yes, we moved to v2.22.1 last night. I'll revert those commits on our
> > servers until we come up with a more permanent solution upstream.
> I think it's sufficient to revert only 5b12e3123b (progress: use
> term_clear_line(), 2019-06-24).  I only mentioned cd1096b282 here
> because it better explains the reasons for having term_clear_line(),
> and an other patch depends on that function as well.

Yes, that's what we did. :) It's out now, so everybody should see the

> > One interesting bit: we have traditionally used \033[K on the _client_
> > side of the sideband demuxer. So I think in the "remote:" case we were
> > already handling this correctly, even before your patch.
> Gah, I feared that the term "sideband multiplexer" will soon come up
> in this discussion...

It may open up some new options for us, though.

If we know on the server side that we are serving a remote request
(which is easy, and does not require client cooperation), can we assume
that the other side will show any sideband lines with its own
end-of-line clearing?

I'm not sure. Git does and always has (and even on a dumb terminal makes
a token effort at throwing some spaces in ;) ). But I'm not sure if
other clients do (and they of course might not even be displaying to a
terminal at all, if they're pulling sideband data into a GUI dialog or


  reply	other threads:[~2019-08-22 17:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-22 14:20 v2.22.1 and later regression wrt display of progress indicators Charles Diza
2019-08-22 16:07 ` SZEDER Gábor
2019-08-22 16:29   ` Jeff King
2019-08-22 16:40     ` SZEDER Gábor
2019-08-22 17:04       ` Jeff King [this message]
2019-08-22 17:19     ` Taylor Blau
2019-09-16 20:54     ` [PATCH 0/2] Revert "progress: use term_clear_line()" SZEDER Gábor
2019-09-16 20:54       ` [PATCH 1/2] " SZEDER Gábor
2019-09-16 20:54       ` [PATCH 2/2] Test the progress display SZEDER Gábor
2019-10-02 15:47       ` [PATCH 0/2] Revert "progress: use term_clear_line()" Jeff King
2019-08-22 17:16   ` v2.22.1 and later regression wrt display of progress indicators Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).