From: Jeff King <peff@peff.net>
To: Derrick Stolee <stolee@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, avarab@gmail.com, garimasigit@gmail.com,
Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH 1/1] fetch: add fetch.writeCommitGraph config setting
Date: Fri, 6 Sep 2019 13:56:28 -0400 [thread overview]
Message-ID: <20190906175628.GH23181@sigill.intra.peff.net> (raw)
In-Reply-To: <a697c4de-e269-c330-ece2-8ac7007e6c55@gmail.com>
On Fri, Sep 06, 2019 at 01:00:40PM -0400, Derrick Stolee wrote:
> On 9/5/2019 4:37 PM, Junio C Hamano wrote:
> > Jeff King <peff@peff.net> writes:
> >
> >> Do we want to to have fetch.writeCommitGraph, receive.writeCommitGraph,
> >> and then a master transfer.writeCommitGraph?
> >
> > If anything, it may be good for consistency.
> >
> > I am not sure if it is a good idea to trigger writing the commit
> > graph when accepting a push, though. It tends to be a lot finer
> > grained than fetching, right?
>
> And I expect a push to include many fewer commits than a fetch.
> In a server environment, I would expect to have a separate
> maintenance task responsible for updating the commit-graph after
> receiving new data, but not in an in-line fashion with the push.
That's probably how we'll end up doing it at GitHub, because we run a
big server farm that has a job-queueing system for periodic maintenance,
etc.
But keep in mind the "little guy" who is hosting a few repositories for
themselves or their company. They'd presumably want the benefits here,
too, right? We already have options to trigger auto-gc and
update-server-info for them, so why not this maintenance, too?
> Think about the situation of many pushes that happen in a short
> burst: one write after all of the pushes would have close to the
> same performance benefits as writing with every push, but does
> a lot less work.
Sure, but wouldn't that similarly apply to fetching? What is it that
makes bursts of pushes more likely than bursts of fetches?
-Peff
next prev parent reply other threads:[~2019-09-06 17:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 2:22 [PATCH 0/1] Write commit-graph on fetch Derrick Stolee via GitGitGadget
2019-09-03 2:22 ` [PATCH 1/1] fetch: add fetch.writeCommitGraph config setting Derrick Stolee via GitGitGadget
2019-09-03 19:05 ` Junio C Hamano
2019-09-03 23:36 ` Derrick Stolee
2019-09-06 21:46 ` Junio C Hamano
2019-09-07 4:51 ` Jeff King
2019-09-09 17:53 ` Junio C Hamano
2019-09-04 3:08 ` Jeff King
2019-09-05 20:37 ` Junio C Hamano
2019-09-06 17:00 ` Derrick Stolee
2019-09-06 17:56 ` Jeff King [this message]
2019-09-06 18:24 ` Junio C Hamano
2019-09-06 19:16 ` Jeff King
2019-09-06 20:42 ` Junio C Hamano
2019-09-06 21:04 ` Derrick Stolee
2019-09-06 21:57 ` Junio C Hamano
2019-09-07 4:47 ` Jeff King
2019-09-07 4:46 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190906175628.GH23181@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=dstolee@microsoft.com \
--cc=garimasigit@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).