From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Derrick Stolee <stolee@gmail.com>,
Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, avarab@gmail.com, garimasigit@gmail.com,
Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH 1/1] fetch: add fetch.writeCommitGraph config setting
Date: Mon, 09 Sep 2019 10:53:23 -0700 [thread overview]
Message-ID: <xmqqmufdl5kc.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190907045101.GD24463@sigill.intra.peff.net> (Jeff King's message of "Sat, 7 Sep 2019 00:51:01 -0400")
Jeff King <peff@peff.net> writes:
> Generation numbers are a little trickier, though, because they imply an
> actual topological traversal. It might actually be easier to couple this
> with the connectivity check we do after index-pack finishes (though I've
> often wondered if we could drop that check in favor of making index-pack
> smarter about finding the boundaries).
Currently after scanning the incoming objects with the fsck
machinery, we count the number of objects that are pointed at by
these objects in the pack and are not in the pack in the
builtin/index-pack.c::check_object() function; at that point, we no
longer know who points at the object in question, which is needed if
we want to compute the boundary, so we need a bit of work here.
With boundary information, we could be smarter about lazy fetching,
I presume?
next prev parent reply other threads:[~2019-09-09 17:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 2:22 [PATCH 0/1] Write commit-graph on fetch Derrick Stolee via GitGitGadget
2019-09-03 2:22 ` [PATCH 1/1] fetch: add fetch.writeCommitGraph config setting Derrick Stolee via GitGitGadget
2019-09-03 19:05 ` Junio C Hamano
2019-09-03 23:36 ` Derrick Stolee
2019-09-06 21:46 ` Junio C Hamano
2019-09-07 4:51 ` Jeff King
2019-09-09 17:53 ` Junio C Hamano [this message]
2019-09-04 3:08 ` Jeff King
2019-09-05 20:37 ` Junio C Hamano
2019-09-06 17:00 ` Derrick Stolee
2019-09-06 17:56 ` Jeff King
2019-09-06 18:24 ` Junio C Hamano
2019-09-06 19:16 ` Jeff King
2019-09-06 20:42 ` Junio C Hamano
2019-09-06 21:04 ` Derrick Stolee
2019-09-06 21:57 ` Junio C Hamano
2019-09-07 4:47 ` Jeff King
2019-09-07 4:46 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmufdl5kc.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=dstolee@microsoft.com \
--cc=garimasigit@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=peff@peff.net \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).