From: Jeff King <peff@peff.net>
To: 16657101987@163.com
Cc: git@vger.kernel.org, gitster@pobox.com, mhagger@alum.mit.edu,
sunchao9@huawei.com, worldhello.net@gmail.com
Subject: Re: [PATCH v2 0/1] pack-refs: always refreshing after take the lock file
Date: Fri, 16 Aug 2019 16:49:06 -0400 [thread overview]
Message-ID: <20190816204906.GA29853@sigill.intra.peff.net> (raw)
In-Reply-To: <20190731183544.24406-1-16657101987@163.com>
On Thu, Aug 01, 2019 at 02:35:43AM +0800, 16657101987@163.com wrote:
> > So I actually think the best path forward is just always refreshing when
> > we take the lock, something like:
> >
> > Ultimately the best solution there is to move to a better format (like
> > the reftables proposal).
>
> I do not know if we could get the new reftables in the next few versions,
> So I commit the changes as you suggested, which is also the same as
> another way I metioned in `PATCH v1`:
>
> **force `update-ref -d` to update the snapshot before rewrite packed-refs.**
>
> But if the reftables is comeing soon, please just ignore my PATCH :)
I'm undecided on this. I think reftables are still a while off, and even
once they are here, many people will still be using the older format. So
it makes sense to still apply fixes to the old code.
What I wonder, though, is whether always refreshing will cause a
noticeable performance impact (and that's why I was so slow in
responding -- I had hoped to try to come up with some numbers, but I
just hadn't gotten around to it).
My gut says it's _probably_ not an issue, but it would be nice to have
some data to back it up.
> **And thank a lot for your reply, it's great to me, because it's my first
> PATCh to git myself :)**
You're welcome. Thanks for diagnosing a rather tricky case. :)
-Peff
next prev parent reply other threads:[~2019-08-16 20:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-21 18:17 [PATCH v1 0/1] pack-refs: pack expired loose refs to packed_refs 16657101987
2019-07-21 18:17 ` [PATCH v1 1/1] " 16657101987
2019-07-30 6:36 ` Jeff King
2019-07-31 18:35 ` [PATCH v2 0/1] pack-refs: always refreshing after take the lock file 16657101987
2019-07-31 18:35 ` [PATCH v2 1/1] " 16657101987
2019-08-16 20:49 ` Jeff King [this message]
2019-08-19 17:36 ` [PATCH v2 0/1] " Junio C Hamano
2019-08-20 15:14 ` 16657101987
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190816204906.GA29853@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=16657101987@163.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
--cc=sunchao9@huawei.com \
--cc=worldhello.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).