git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: 16657101987@163.com
To: gitster@pobox.com
Cc: 16657101987@163.com, git@vger.kernel.org, mhagger@alum.mit.edu,
	peff@peff.net, sunchao9@huawei.com, worldhello.net@gmail.com
Subject: Re: Re: [PATCH v2 0/1] pack-refs: always refreshing after take the lock file
Date: Tue, 20 Aug 2019 23:14:08 +0800	[thread overview]
Message-ID: <20190820151408.12700-1-16657101987@163.com> (raw)
In-Reply-To: <xmqqr25hxdk6.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <xmqqr25hxdk6.fsf@gitster-ct.c.googlers.com>

From: Sun Chao <sunchao9@huawei.com>

---

Jeff King <peff@peff.net> writes:

> I'm undecided on this. I think reftables are still a while off, and even
> once they are here, many people will still be using the older format. So
> it makes sense to still apply fixes to the old code.

Got it, thanks for explainning.

> What I wonder, though, is whether always refreshing will cause a
> noticeable performance impact (and that's why I was so slow in
> responding -- I had hoped to try to come up with some numbers, but I
> just hadn't gotten around to it).
>
> My gut says it's _probably_ not an issue, but it would be nice to have
> some data to back it up.

Sorry for responding after 4 days because I have been away on official
business.

Tody I have tryied some tools like trace logs, time, and strace, tring
to figure out if there are some noticeable numbers. I tried different
repositories with different ref numbers and blob numbers, I also can
not recognize how much the refreshing impact the performance, perhaps
I need to find a better computer for benchmark testing.

---

Junio C Hamano <gitster@pobox.com> writes:

> I am tempted to let correctness (and ease-of-reasoning about the
> code) take precedence over potential and unknown performance issue,
> at least for now.  A single liner is rather simple to revert (or in
> the worst case we could add "allow pack-refs to efficiently lose a
> ref to a race" configuration option) anyway.

Thanks a lot :)

-- 
2.17.2 (Apple Git-113)



      reply	other threads:[~2019-08-20 15:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-21 18:17 [PATCH v1 0/1] pack-refs: pack expired loose refs to packed_refs 16657101987
2019-07-21 18:17 ` [PATCH v1 1/1] " 16657101987
2019-07-30  6:36   ` Jeff King
2019-07-31 18:35     ` [PATCH v2 0/1] pack-refs: always refreshing after take the lock file 16657101987
2019-07-31 18:35       ` [PATCH v2 1/1] " 16657101987
2019-08-16 20:49       ` [PATCH v2 0/1] " Jeff King
2019-08-19 17:36         ` Junio C Hamano
2019-08-20 15:14           ` 16657101987 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190820151408.12700-1-16657101987@163.com \
    --to=16657101987@163.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=mhagger@alum.mit.edu \
    --cc=peff@peff.net \
    --cc=sunchao9@huawei.com \
    --cc=worldhello.net@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).