From: Todd Zullinger <tmz@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>,
"René Scharfe" <l.s.r@web.de>,
"Randall S. Becker" <rsbecker@nexbridge.com>,
"'Junio C Hamano'" <gitster@pobox.com>,
"Christian Couder" <chriscool@tuxfamily.org>,
git@vger.kernel.org, git-packagers@googlegroups.com
Subject: Re: [ANNOUNCE] Git v2.23.0-rc0 - Initial test failures on NonStop
Date: Wed, 31 Jul 2019 02:04:49 -0400 [thread overview]
Message-ID: <20190731060449.GE4545@pobox.com> (raw)
In-Reply-To: <20190731032735.GA14684@sigill.intra.peff.net>
Jeff King wrote:
> On Tue, Jul 30, 2019 at 09:59:17PM -0400, Todd Zullinger wrote:
>> At the risk of showing my complete lack of knowledge about
>> these tests, I was wondering if the order mattered for the
>> other tests in t0011 and t0016.
[...]
>> You've got a more comprehensive patch and a proper commit
>> message, so this is really just a matter of curiosity.
>
> I think the order does matter for those ones. E.g., the ones that run
> "get" want to make sure they're seeing the values in the same order in
> which they were requested.
Ahh, thanks for clarifying that (and saving me from sending
the version I had which would have incorrectly sorted all
the test_{hashmap,oidmap} output. :)
FWIW, I applied your patch for sorting hashmap iterations
(<20190731012336.GA13880@sigill.intra.peff.net>¹) and ran it
through the Fedora build system. All architectures passed,
as expected.
¹ https://public-inbox.org/git/20190731012336.GA13880@sigill.intra.peff.net/
--
Todd
next prev parent reply other threads:[~2019-07-31 6:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 17:08 [ANNOUNCE] Git v2.23.0-rc0 - Initial test failures on NonStop Randall S. Becker
2019-07-30 17:31 ` Junio C Hamano
2019-07-30 18:09 ` Matheus Tavares Bernardino
2019-07-30 18:10 ` Randall S. Becker
2019-07-30 18:35 ` Junio C Hamano
2019-07-30 19:45 ` Jeff King
2019-07-30 20:25 ` Randall S. Becker
2019-07-30 19:49 ` Todd Zullinger
2019-07-30 20:02 ` Jeff King
2019-07-30 20:39 ` Junio C Hamano
2019-07-30 20:56 ` SZEDER Gábor
2019-07-31 0:59 ` Jeff King
2019-07-31 1:23 ` Jeff King
2019-07-31 1:27 ` Jeff King
2019-07-31 1:59 ` Todd Zullinger
2019-07-31 3:27 ` Jeff King
2019-07-31 3:53 ` Jeff King
2019-07-31 17:17 ` Junio C Hamano
2019-07-31 21:22 ` non-cryptographic hash algorithms in git Jeff King
2019-07-31 4:06 ` [ANNOUNCE] Git v2.23.0-rc0 - Initial test failures on NonStop René Scharfe
2019-07-31 4:30 ` Jeff King
2019-07-31 6:04 ` Todd Zullinger [this message]
2019-07-31 16:57 ` Junio C Hamano
2019-07-30 20:27 ` Randall S. Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190731060449.GE4545@pobox.com \
--to=tmz@pobox.com \
--cc=chriscool@tuxfamily.org \
--cc=git-packagers@googlegroups.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=peff@peff.net \
--cc=rsbecker@nexbridge.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).