From: Jeff King <peff@peff.net>
To: "René Scharfe" <l.s.r@web.de>
Cc: "Todd Zullinger" <tmz@pobox.com>,
"SZEDER Gábor" <szeder.dev@gmail.com>,
"Randall S. Becker" <rsbecker@nexbridge.com>,
"'Junio C Hamano'" <gitster@pobox.com>,
"Christian Couder" <chriscool@tuxfamily.org>,
git@vger.kernel.org, git-packagers@googlegroups.com
Subject: Re: [ANNOUNCE] Git v2.23.0-rc0 - Initial test failures on NonStop
Date: Wed, 31 Jul 2019 00:30:39 -0400 [thread overview]
Message-ID: <20190731043039.GB26237@sigill.intra.peff.net> (raw)
In-Reply-To: <b32a178d-0255-6c82-a3fd-ced2ec828fc8@web.de>
On Wed, Jul 31, 2019 at 06:06:02AM +0200, René Scharfe wrote:
> Am 31.07.19 um 05:27 schrieb Jeff King:
> > One thing that makes it all a bit funky is that the "put" lines also
> > output the old value (which is what all those NULLs) are. And I think
> > that solves my "value3" puzzlement from earlier. It is not part of the
> > iteration at all, but rather the result of the duplicate "put".
> >
> > That would perhaps be clearer if the "hashmap" tool actually did the
> > sorting itself (so we'd sort _just_ the iteration, not the whole
> > output). Something like this, though I'm on the fence about whether it
> > is worth it:
>
> We already have a few other tests that sort and compare. Perhaps it's
> time for a test_cmp_ignore_order?
That would be OK with me, but I think it would just replace the calls to
"sort". To do the "just sort the iteration, but not the rest of the
output that I'm talking about above", the change _has_ to go into
test-hashmap.c (but I think I still favor just sorting the whole thing
for simplicity).
> And perhaps something like this might even be worth implementing as a
> diff option? https://github.com/l0b0/diff-ignore-moved-lines has
> post-processing script for that..
Given that we don't actually care that much about looking at the
resulting diff (and so we don't care about preserving order), I think
just sorting both sides gives equivalent results and is much simpler.
-Peff
next prev parent reply other threads:[~2019-07-31 4:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 17:08 [ANNOUNCE] Git v2.23.0-rc0 - Initial test failures on NonStop Randall S. Becker
2019-07-30 17:31 ` Junio C Hamano
2019-07-30 18:09 ` Matheus Tavares Bernardino
2019-07-30 18:10 ` Randall S. Becker
2019-07-30 18:35 ` Junio C Hamano
2019-07-30 19:45 ` Jeff King
2019-07-30 20:25 ` Randall S. Becker
2019-07-30 19:49 ` Todd Zullinger
2019-07-30 20:02 ` Jeff King
2019-07-30 20:39 ` Junio C Hamano
2019-07-30 20:56 ` SZEDER Gábor
2019-07-31 0:59 ` Jeff King
2019-07-31 1:23 ` Jeff King
2019-07-31 1:27 ` Jeff King
2019-07-31 1:59 ` Todd Zullinger
2019-07-31 3:27 ` Jeff King
2019-07-31 3:53 ` Jeff King
2019-07-31 17:17 ` Junio C Hamano
2019-07-31 21:22 ` non-cryptographic hash algorithms in git Jeff King
2019-07-31 4:06 ` [ANNOUNCE] Git v2.23.0-rc0 - Initial test failures on NonStop René Scharfe
2019-07-31 4:30 ` Jeff King [this message]
2019-07-31 6:04 ` Todd Zullinger
2019-07-31 16:57 ` Junio C Hamano
2019-07-30 20:27 ` Randall S. Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190731043039.GB26237@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=chriscool@tuxfamily.org \
--cc=git-packagers@googlegroups.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=rsbecker@nexbridge.com \
--cc=szeder.dev@gmail.com \
--cc=tmz@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).