From: Jeff King <peff@peff.net>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [RFC/PATCH 2/5] t5801 (remote-helpers): add test to fetch tags
Date: Tue, 4 Jun 2019 10:22:33 -0400 [thread overview]
Message-ID: <20190604142233.GB10598@sigill.intra.peff.net> (raw)
In-Reply-To: <20190604021330.16130-3-felipe.contreras@gmail.com>
On Mon, Jun 03, 2019 at 09:13:27PM -0500, Felipe Contreras wrote:
> This used to work, but commit e198b3a740 broke it.
>
> e198b3a740 (fetch: replace string-list used as a look-up table with a hashmap)
>
> Probably all remote helpers that use the import method are affected, but
> we didn't catch the issue.
Thanks for beefing up the tests. It's rather unfortunate that we missed
such a severe regression.
> +test_expect_failure 'fetch tag' '
> + (cd server &&
> + git tag v1.0
> + ) &&
> + (cd local &&
> + git fetch
> + ) &&
> + compare_refs local v1.0 server v1.0
> +'
This single-commands might be more readable using "git -C", but this
matches the existing style in the test script, so I'm OK with it either
way.
> diff --git a/t/t5801/git-remote-testgit b/t/t5801/git-remote-testgit
> index f2b551dfaf..6b9f0b5dc7 100755
> --- a/t/t5801/git-remote-testgit
> +++ b/t/t5801/git-remote-testgit
> @@ -12,9 +12,14 @@ url=$2
>
> dir="$GIT_DIR/testgit/$alias"
>
> -refspec="refs/heads/*:refs/testgit/$alias/heads/*"
> +h_refspec="refs/heads/*:refs/testgit/$alias/heads/*"
> +t_refspec="refs/tags/*:refs/testgit/$alias/tags/*"
>
> -test -n "$GIT_REMOTE_TESTGIT_NOREFSPEC" && refspec=""
> +if test -n "$GIT_REMOTE_TESTGIT_NOREFSPEC"
> +then
> + h_refspec=""
> + t_refspec=""
> +fi
And the simplification from the prior step pays off. Looks good.
The rest of it seems pretty sensible (modulo the caveat that I don't know
remote-testgit well enough to detect anything subtle).
-Peff
next prev parent reply other threads:[~2019-06-04 14:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 2:13 [RFC/PATCH 0/5] Fix fetch regression with transport helpers Felipe Contreras
2019-06-04 2:13 ` [RFC/PATCH 1/5] t5801 (remote-helpers): cleanup refspec stuff Felipe Contreras
2019-06-04 14:16 ` Jeff King
2019-06-04 2:13 ` [RFC/PATCH 2/5] t5801 (remote-helpers): add test to fetch tags Felipe Contreras
2019-06-04 14:22 ` Jeff King [this message]
2019-06-04 2:13 ` [RFC/PATCH 3/5] fetch: trivial cleanup Felipe Contreras
2019-06-04 2:13 ` [RFC/PATCH 4/5] fetch: make the code more understandable Felipe Contreras
2019-06-04 2:13 ` [RFC/PATCH 5/5] fetch: fix regression with transport helpers Felipe Contreras
2019-06-04 14:32 ` Jeff King
2019-06-04 19:17 ` Junio C Hamano
2019-06-04 14:35 ` [RFC/PATCH 0/5] Fix fetch " Jeff King
2019-06-04 19:15 ` Felipe Contreras
2019-06-05 8:12 ` Johannes Schindelin
2019-06-05 11:27 ` Jeff King
2019-06-05 12:22 ` Duy Nguyen
2019-06-06 13:07 ` Johannes Schindelin
2019-06-06 16:13 ` Junio C Hamano
2019-06-07 5:32 ` CI builds on GitGitGadget, was " Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190604142233.GB10598@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).