From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Michael Osipov" <michael.osipov@siemens.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: [PATCH] sha1dc: update from upstream
Date: Tue, 14 May 2019 00:17:01 +0200 [thread overview]
Message-ID: <20190513221701.1837-1-avarab@gmail.com> (raw)
In-Reply-To: <3cabed9e-3949-93cc-2c9c-500a9cd9d4cd@siemens.com>
Update sha1dc from the latest version by the upstream
maintainer[1]. See 07a20f569b ("Makefile: fix unaligned loads in
sha1dc with UBSan", 2019-03-12) for the last update.
This fixes an issue where HP-UX IA64 was wrongly detected as a
Little-endian instead of a Big-endian system, see [2] and [3].
1. https://github.com/cr-marcstevens/sha1collisiondetection/commit/855827c583bc30645ba427885caa40c5b81764d2
2. https://public-inbox.org/git/603989bd-f86d-c61d-c6f5-fb6748a65ba9@siemens.com/
3. https://github.com/cr-marcstevens/sha1collisiondetection/pull/50
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
n Thu, May 09 2019, Osipov, Michael wrote:
> Hey there,
>
> Am 2019-05-09 um 09:32 schrieb Ævar Arnfjörð Bjarmason:
>>
>> On Wed, May 08 2019, Osipov, Michael wrote:
>>
>>> Hi folks,
>>
>> Hi see Documentation/SubmittingPatches for how to submit patches inline
>> instead of as attachments.
>
> Do you want me to resend the configure.ac change as per wiki article?
> I can also create a PR on GitHub. I am happy with both as long as I
> don't have to retain the patch for myself only ;-)
Yeah that patch to git.git should be done separately. I see your PR
went in upstream, here's a patch to update our code to match.
> That'd be much more work to extend configure.ac for that because is a
> runtime check. Since there are no real products vailable on x86 for
> HP-UX I'd neglect that. Our HPE salesman told us that this will be
> available somewhere in the future. So, I think this is very good for
> now.
Sure, makes sense. I'm not familiar with HP/UX. So just thought I'd
ask.
sha1collisiondetection | 2 +-
sha1dc/sha1.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sha1collisiondetection b/sha1collisiondetection
index 16033998da..855827c583 160000
--- a/sha1collisiondetection
+++ b/sha1collisiondetection
@@ -1 +1 @@
-Subproject commit 16033998da4b273aebd92c84b1e1b12e4aaf7009
+Subproject commit 855827c583bc30645ba427885caa40c5b81764d2
diff --git a/sha1dc/sha1.c b/sha1dc/sha1.c
index 5931cf25d5..9d3cf81d4d 100644
--- a/sha1dc/sha1.c
+++ b/sha1dc/sha1.c
@@ -93,7 +93,7 @@
#define SHA1DC_BIGENDIAN
/* Not under GCC-alike or glibc or *BSD or newlib or <processor whitelist> */
-#elif (defined(_AIX))
+#elif (defined(_AIX) || defined(__hpux))
/*
* Defines Big Endian on a whitelist of OSs that are known to be Big
--
2.21.0.1020.gf2820cf01a
next prev parent reply other threads:[~2019-05-13 22:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 10:45 [PATCH] Improving HP-UX support Osipov, Michael
2019-05-09 7:32 ` Ævar Arnfjörð Bjarmason
2019-05-09 8:09 ` Osipov, Michael
2019-05-13 22:17 ` Ævar Arnfjörð Bjarmason [this message]
2019-05-14 11:17 ` [PATCH] sha1dc: update from upstream Osipov, Michael
2019-05-15 11:48 ` Ævar Arnfjörð Bjarmason
2019-05-16 7:13 ` Osipov, Michael
2019-05-16 8:31 ` Ævar Arnfjörð Bjarmason
2019-05-16 8:40 ` Osipov, Michael
2019-05-16 9:34 ` [PATCH] configure: Detect linking style for HP aCC on HP-UX Ævar Arnfjörð Bjarmason
2019-05-16 18:05 ` [PATCH] Makefile: remove the NO_R_TO_GCC_LINKER flag Ævar Arnfjörð Bjarmason
2019-05-16 22:25 ` Jeff King
2019-05-16 23:21 ` Junio C Hamano
2019-05-17 0:23 ` Jeff King
2019-05-17 21:58 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2019-05-19 0:56 ` Junio C Hamano
2019-05-19 5:01 ` Jeff King
2019-06-07 14:51 ` [PATCH] configure: Detect linking style for HP aCC on HP-UX Osipov, Michael
2019-06-07 17:03 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2018-08-01 7:31 Is detecting endianness at compile-time unworkable? Ævar Arnfjörð Bjarmason
2018-08-02 20:50 ` [PATCH] sha1dc: update from upstream Ævar Arnfjörð Bjarmason
2018-08-02 21:29 ` Michael Felt (aixtools)
2018-08-02 21:32 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190513221701.1837-1-avarab@gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=michael.osipov@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).