From: "Osipov, Michael" <michael.osipov@siemens.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Improving HP-UX support
Date: Thu, 9 May 2019 10:09:40 +0200 [thread overview]
Message-ID: <3cabed9e-3949-93cc-2c9c-500a9cd9d4cd@siemens.com> (raw)
In-Reply-To: <87lfzggk1n.fsf@evledraar.gmail.com>
Hey there,
Am 2019-05-09 um 09:32 schrieb Ævar Arnfjörð Bjarmason:
>
> On Wed, May 08 2019, Osipov, Michael wrote:
>
>> Hi folks,
>
> Hi see Documentation/SubmittingPatches for how to submit patches inline
> instead of as attachments.
Do you want me to resend the configure.ac change as per wiki article? I
can also create a PR on GitHub. I am happy with both as long as I don't
have to retain the patch for myself only ;-)
> For the sha1dc change it seems trivially correct, but we import that
> upstream project as-is, could you please submit a pull request at
> https://github.com/cr-marcstevens/sha1collisiondetection then we can
> update our version?
Sure thing, will do.
>> diff -ur configure.ac configure.ac
>> --- configure.ac 2019-02-24 16:55:19 +0000
>> +++ configure.ac 2019-05-08 11:31:42 +0000
>> @@ -475,8 +475,18 @@
>> if test "$git_cv_ld_rpath" = "yes"; then
>> CC_LD_DYNPATH=-rpath
>> else
>> - CC_LD_DYNPATH=
>> - AC_MSG_WARN([linker does not support runtime path to dynamic libraries])
>> + AC_CACHE_CHECK([if linker supports -Wl,+b,], git_cv_ld_wl_b, [
>> + SAVE_LDFLAGS="${LDFLAGS}"
>> + LDFLAGS="${SAVE_LDFLAGS} -Wl,+b,/"
>> + AC_LINK_IFELSE([AC_LANG_PROGRAM([], [])], [git_cv_ld_wl_b=yes], [git_cv_ld_wl_b=no])
>> + LDFLAGS="${SAVE_LDFLAGS}"
>> + ])
>> + if test "$git_cv_ld_wl_b" = "yes"; then
>> + CC_LD_DYNPATH=-Wl,+b,
>> + else
>> + CC_LD_DYNPATH=
>> + AC_MSG_WARN([linker does not support runtime path to dynamic libraries])
>> + fi
>> fi
>> fi
>> fi
>
> Do we want to also have something in config.mak.uname to always do this
> on HP/UX?
I am not convinced by that. I wouldn't mix operating system with
compiler settings. One could also use GCC on HP-UX. The one above is for
HP aCC.
>> /* Not under GCC-alike or glibc or *BSD or newlib or <processor whitelist> */
>> -#elif (defined(_AIX))
>> +#elif (defined(_AIX) || defined(__hpux))
>
> Seems sane, and per my googling even though HP/UX now runs on
> little-endian hardware it's always big-endian. But in this manual they
> advice doing it at runtime with a TEST_ENDIAN() macro in sys/portal.h:
> http://h20628.www2.hp.com/km-ext/kmcsdirect/emr_na-c01921401-1.pdf
>
> Is that something we need to worry about / support? E.g. in the
> configure script?
>
That'd be much more work to extend configure.ac for that because is a
runtime check. Since there are no real products vailable on x86 for
HP-UX I'd neglect that. Our HPE salesman told us that this will be
available somewhere in the future. So, I think this is very good for now.
Michael
next prev parent reply other threads:[~2019-05-09 8:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 10:45 [PATCH] Improving HP-UX support Osipov, Michael
2019-05-09 7:32 ` Ævar Arnfjörð Bjarmason
2019-05-09 8:09 ` Osipov, Michael [this message]
2019-05-13 22:17 ` [PATCH] sha1dc: update from upstream Ævar Arnfjörð Bjarmason
2019-05-14 11:17 ` Osipov, Michael
2019-05-15 11:48 ` Ævar Arnfjörð Bjarmason
2019-05-16 7:13 ` Osipov, Michael
2019-05-16 8:31 ` Ævar Arnfjörð Bjarmason
2019-05-16 8:40 ` Osipov, Michael
2019-05-16 9:34 ` [PATCH] configure: Detect linking style for HP aCC on HP-UX Ævar Arnfjörð Bjarmason
2019-05-16 18:05 ` [PATCH] Makefile: remove the NO_R_TO_GCC_LINKER flag Ævar Arnfjörð Bjarmason
2019-05-16 22:25 ` Jeff King
2019-05-16 23:21 ` Junio C Hamano
2019-05-17 0:23 ` Jeff King
2019-05-17 21:58 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2019-05-19 0:56 ` Junio C Hamano
2019-05-19 5:01 ` Jeff King
2019-06-07 14:51 ` [PATCH] configure: Detect linking style for HP aCC on HP-UX Osipov, Michael
2019-06-07 17:03 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cabed9e-3949-93cc-2c9c-500a9cd9d4cd@siemens.com \
--to=michael.osipov@siemens.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).