From: Jeff King <peff@peff.net>
To: Christian Couder <christian.couder@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Bartosz Baranowski <bbaranow@redhat.com>,
git <git@vger.kernel.org>
Subject: Re: [PATCH 2/3] bisect: fix internal diff-tree config loading
Date: Mon, 4 Mar 2019 23:15:15 -0500 [thread overview]
Message-ID: <20190305041515.GC19800@sigill.intra.peff.net> (raw)
In-Reply-To: <CAP8UFD0+MSaU4KmD_pfHnCDFoqr9H99Fp9tBP-Qw+vs+ambgFg@mail.gmail.com>
On Sun, Mar 03, 2019 at 06:59:19PM +0100, Christian Couder wrote:
> On Fri, Feb 22, 2019 at 7:21 AM Jeff King <peff@peff.net> wrote:
> >
> > When we run our internal diff-tree to show the bisected commit, we call
> > init_revisions(), then load config, then setup_revisions(). But that
> > order is wrong: we copy the configured defaults into the rev_info struct
> > during the init_revisions step, so our config load wasn't actually doing
> > anything.
> >
> > Signed-off-by: Jeff King <peff@peff.net>
> > ---
> > It does feel a little weird loading config at all here, since it would
> > potentially affect other in-process operations.
>
> I like that this patch fixes a bug, but this still triggers some
> wondering/comments.
>
> Would it be better or at least less weird to load it at the beginning
> of `git bisect`?
I guess you mean at the beginning of bisect--helper? That would be OK
with me, too, and maybe would be a little less weird. But if bisect is
slowly becoming a single binary, maybe we should just wait for that.
> Or is the real problem a limitation of the config system, that prevent
> us from temporarily loading, and then maybe unloading, some config?
It's less the config system, and more the way Git is written. ;)
Typically parsing the config means setting a bunch of globals, and
forgetting what their original values are. That's not something the
config system can fix.
-Peff
next prev parent reply other threads:[~2019-03-05 4:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 10:47 git bisect - good vs bad output is different Bartosz Baranowski
2019-02-21 21:39 ` Junio C Hamano
2019-02-22 6:19 ` [PATCH 0/3] prettier bisect output Jeff King
2019-02-22 6:20 ` [PATCH 1/3] bisect: use string arguments to feed internal diff-tree Jeff King
2019-02-22 6:21 ` [PATCH 2/3] bisect: fix internal diff-tree config loading Jeff King
2019-03-03 17:59 ` Christian Couder
2019-03-05 4:15 ` Jeff King [this message]
2019-02-22 6:23 ` [PATCH 3/3] bisect: make diff-tree output prettier Jeff King
2019-02-22 17:49 ` Junio C Hamano
2019-02-23 13:44 ` Jeff King
2019-03-03 18:25 ` Christian Couder
2019-02-22 17:39 ` [PATCH 0/3] prettier bisect output Junio C Hamano
2019-03-03 18:33 ` Christian Couder
2019-03-05 4:16 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190305041515.GC19800@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=bbaranow@redhat.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).