mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Christian Couder <>
To: Jeff King <>
Cc: Junio C Hamano <>,
	Bartosz Baranowski <>,
	git <>
Subject: Re: [PATCH 2/3] bisect: fix internal diff-tree config loading
Date: Sun, 3 Mar 2019 18:59:19 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, Feb 22, 2019 at 7:21 AM Jeff King <> wrote:
> When we run our internal diff-tree to show the bisected commit, we call
> init_revisions(), then load config, then setup_revisions(). But that
> order is wrong: we copy the configured defaults into the rev_info struct
> during the init_revisions step, so our config load wasn't actually doing
> anything.
> Signed-off-by: Jeff King <>
> ---
> It does feel a little weird loading config at all here, since it would
> potentially affect other in-process operations.

I like that this patch fixes a bug, but this still triggers some

Would it be better or at least less weird to load it at the beginning
of `git bisect`?

Or is the real problem a limitation of the config system, that prevent
us from temporarily loading, and then maybe unloading, some config?

> This is where an
> external process might be cleaner.

It depends on which definition of clean we use. Yeah, having many
global variables and not caring because we launch many external
processes that will "clean" things up when they exit can seem "clean"
for some time. But I think we are past this point now, and I still
wouldn't like us to go back to our previous way of doing things even
here. So thanks for not using an external process.

Thanks for working on this,

  reply	other threads:[~2019-03-03 17:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-21 10:47 git bisect - good vs bad output is different Bartosz Baranowski
2019-02-21 21:39 ` Junio C Hamano
2019-02-22  6:19   ` [PATCH 0/3] prettier bisect output Jeff King
2019-02-22  6:20     ` [PATCH 1/3] bisect: use string arguments to feed internal diff-tree Jeff King
2019-02-22  6:21     ` [PATCH 2/3] bisect: fix internal diff-tree config loading Jeff King
2019-03-03 17:59       ` Christian Couder [this message]
2019-03-05  4:15         ` Jeff King
2019-02-22  6:23     ` [PATCH 3/3] bisect: make diff-tree output prettier Jeff King
2019-02-22 17:49       ` Junio C Hamano
2019-02-23 13:44         ` Jeff King
2019-03-03 18:25           ` Christian Couder
2019-02-22 17:39     ` [PATCH 0/3] prettier bisect output Junio C Hamano
2019-03-03 18:33     ` Christian Couder
2019-03-05  4:16       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).